Open
Conversation
NattyNarwhal
changed the title
NattyNarwhal
force-pushed
the
odbc-row-arg-deprecation
branch
from
74dec6d to
882023b
Compare
Member
|
I think this doesn't require an RFC any more due to the recent policy change. |
odbc_fetch_row was changed to have $row be nullable and null by default instead of using 0, but still accepted 0 due to old code being explicit. Remove that special handling. See phpGH-13910. This should be merged if it passes in the 8.6 deprecations RFC.
When we're testing the error, change to match the updated description, when we're testing the default case, update from 0->1.
Rather than having the implicit default twice; keeps the test similar.
NattyNarwhal
force-pushed
the
odbc-row-arg-deprecation
branch
from
882023b to
27c025f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
odbc_fetch_row was changed to have $row be nullable and null by default instead of using 0, but still accepted 0 due to old code being explicit. Remove that special handling. Also change the message to accurately describe all possible functions.
See GH-13910. This should be merged if it passes in the 8.6 deprecations RFC.