Skip to content

Add warning about Mt19937 global state in legacy random functions #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lacatoire merged 1 commit into from
Mar 24, 2026
Merged

Add warning about Mt19937 global state in legacy random functions #2689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion language-snippets.ent
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- EN-Revision: c6fb604f39a0fa7bf1ae872064b2a3a24f23d855 Maintainer: yannick Status: ready -->
<!-- EN-Revision: d6dc2be3c5c70e4a1c3d13f788643ea232747c19 Maintainer: lacatoire Status: ready -->
<!-- Reviewed: no -->
<!-- Relecture des Notes, Précautions, Avertissements, Astuces, Divers et Retour le 2018-12-29 par girgias -->

Expand Down Expand Up @@ -39,6 +39,19 @@ de nombres aléatoires est initialisé automatiquement.</entry></row>'>
</para>
</caution>'>

<!ENTITY caution.mt19937-global-state '<caution xmlns="http://docbook.org/ns/docbook">
<simpara>
Cette fonction utilise l&#39;instance globale Mt19937 ("Mersenne Twister") comme source d&#39;aléatoire et partage ainsi son état avec toutes les autres fonctions utilisant le Mt19937 global.
L&#39;utilisation de l&#39;une de ces fonctions fait avancer la séquence pour <emphasis>toutes</emphasis> les autres fonctions, indépendamment de la portée.
</simpara>
<simpara>
Générer des séquences reproductibles en initialisant <function>mt_srand</function> ou <function>srand</function> avec une valeur connue produira également une sortie reproductible de cette fonction.
</simpara>
<simpara>
Il est préférable d&#39;utiliser les méthodes de <classname>Random\Randomizer</classname> dans tout nouveau code.
</simpara>
</caution>'>

<!ENTITY caution.mt19937-tiny-seed '<caution xmlns="http://docbook.org/ns/docbook">
<para>
Étant donné que le moteur Mt19937 ("Mersenne Twister") prend un seul entier de 32 bits en tant que
Expand Down
3 changes: 2 additions & 1 deletion reference/array/functions/array-rand.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- $Revision$ -->
<!-- EN-Revision: 4a1dedc24b1e085f298ab1d5dadefe306373691b Maintainer: yannick Status: ready -->
<!-- EN-Revision: d6dc2be3c5c70e4a1c3d13f788643ea232747c19 Maintainer: lacatoire Status: ready -->
<!-- Reviewed: no -->
<!-- CREDITS: DavidA. -->

Expand All @@ -21,6 +21,7 @@
et retourne la ou les clés de ces valeurs.
</para>
&caution.cryptographically-insecure;
&caution.mt19937-global-state;
</refsect1>

<refsect1 role="parameters">
Expand Down
3 changes: 2 additions & 1 deletion reference/array/functions/shuffle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- $Revision$ -->
<!-- EN-Revision: f781803449007bb0e3a96c693e0eee067f7eb466 Maintainer: yannick Status: ready -->
<!-- EN-Revision: d6dc2be3c5c70e4a1c3d13f788643ea232747c19 Maintainer: lacatoire Status: ready -->
<!-- Reviewed: no -->
<!-- CREDITS: DavidA. -->

Expand All @@ -19,6 +19,7 @@
Mélange les éléments du tableau <parameter>array</parameter>.
</para>
&caution.cryptographically-insecure;
&caution.mt19937-global-state;
</refsect1>
<refsect1 role="parameters">
&reftitle.parameters;
Expand Down
3 changes: 2 additions & 1 deletion reference/random/functions/mt-rand.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- $Revision$ -->
<!-- EN-Revision: 0a5e7b12546b62a611a0cbc7105e617ab96fbcbd Maintainer: yannick Status: ready -->
<!-- EN-Revision: d6dc2be3c5c70e4a1c3d13f788643ea232747c19 Maintainer: lacatoire Status: ready -->
<!-- Reviewed: no -->

<refentry xml:id="function.mt-rand" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink">
Expand Down Expand Up @@ -36,6 +36,7 @@
<literal>mt_rand(5,15)</literal>.
</simpara>
&caution.cryptographically-insecure;
&caution.mt19937-global-state;
</refsect1>

<refsect1 role="parameters">
Expand Down
3 changes: 2 additions & 1 deletion reference/random/functions/rand.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- $Revision$ -->
<!-- EN-Revision: a2a3f3525979535f7f8c81b79315391f2fdc285b Maintainer: yannick Status: ready -->
<!-- EN-Revision: d6dc2be3c5c70e4a1c3d13f788643ea232747c19 Maintainer: lacatoire Status: ready -->
<!-- Reviewed: no -->

<refentry xml:id="function.rand" xmlns="http://docbook.org/ns/docbook">
Expand All @@ -27,6 +27,7 @@
(inclus), par exemple, utiliser <literal>rand (5, 15)</literal>.
</simpara>
&caution.cryptographically-insecure;
&caution.mt19937-global-state;
<note>
<simpara>
Avant PHP 7.1.0, <function>getrandmax</function> valait seulement 32767 sur certaines plateformes
Expand Down
3 changes: 2 additions & 1 deletion reference/strings/functions/str-shuffle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- $Revision$ -->
<!-- EN-Revision: 52c495140bdb84f45f186bfb1cccf09788b0121e Maintainer: yannick Status: ready -->
<!-- EN-Revision: d6dc2be3c5c70e4a1c3d13f788643ea232747c19 Maintainer: lacatoire Status: ready -->
<!-- Reviewed: no -->
<refentry xml:id="function.str-shuffle" xmlns="http://docbook.org/ns/docbook" xmlns:xlink="http://www.w3.org/1999/xlink">
<refnamediv>
Expand All @@ -19,6 +19,7 @@
Une permutation parmi toutes celles possibles est créée.
</simpara>
&caution.cryptographically-insecure;
&caution.mt19937-global-state;
</refsect1>

<refsect1 role="parameters">
Expand Down
Loading