Add a warning about the subtle global state in legacy random functions#5414
Merged
TimWolla merged 1 commit intophp:masterfrom Mar 23, 2026
Merged
Add a warning about the subtle global state in legacy random functions#5414TimWolla merged 1 commit intophp:masterfrom
TimWolla merged 1 commit intophp:masterfrom
Conversation
TimWolla
reviewed
Mar 9, 2026
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
Thank you. I need to think about this a little more. Perhaps it's best to also have a generic “global state bad” message on the affected functions and just mention the fork gotcha in an “aside”.
Girgias
requested changes
Mar 10, 2026
anthonyryan1
changed the title
Contributor
Author
|
I've refocused this on simply being a warning on the legacy random pages. Let me know if you'd like to see any other changes or improvements. I've left pcntl out entirely, because arguably this problem is just that these functions still exist and the flaw is their use, rather than any overlap with pcntl. |
TimWolla
reviewed
Mar 10, 2026
anthonyryan1
force-pushed
the
master
branch
6 times, most recently
from
066688d to
317d8dd
Compare
TimWolla
requested changes
Mar 17, 2026
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
Request changes for visibility of: #5414 (comment)
TimWolla
approved these changes
Mar 23, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes php/php-src#21351
Replaces php/php-src#21352