Skip to content

PHP 8.1 | Migration guide: add IMAGETYPE_AVIF constant#5043

Merged
cweiske merged 2 commits intophp:masterfrom
rodrigoprimo:update-8.1-migration-guide
Mar 23, 2026
Merged

PHP 8.1 | Migration guide: add IMAGETYPE_AVIF constant#5043
cweiske merged 2 commits intophp:masterfrom
rodrigoprimo:update-8.1-migration-guide

Conversation

@rodrigoprimo
Copy link
Copy Markdown
Contributor

Add the IMAGETYPE_AVIF constant to the PHP 8.1 migration guide.

The Standard section was placed at the end of the file, after Tokenizer, following the pattern used in the PHP 8.5 migration guide. I'm not sure if this is correct or not.

Refs:

Add the `IMAGETYPE_AVIF` constant to the PHP 8.1 migration guide.

The Standard section was placed at the end of the file, after Tokenizer, following the pattern used in the PHP 8.5 migration guide. I'm not sure if this is correct or not.

Refs:
* php/php-src#7091
@lacatoire
Copy link
Copy Markdown
Member

LGTM! Thanks @rodrigoprimo IMAGETYPE_AVIF confirmed in src

@cweiske
Copy link
Copy Markdown
Contributor

cweiske commented Mar 23, 2026

Please sort the ids/sections alphabetically (put yours into the correct sort position).

@rodrigoprimo
Copy link
Copy Markdown
Contributor Author

rodrigoprimo commented Mar 23, 2026

Thanks for the review and for confirming the correct sort order, @cweiske!

I applied your suggestion. The Standard section is now in its correct alphabetical position, between Sodium and Tokenizer.

As mentioned in the PR description, I had originally placed it at the end following the pattern used in the PHP 8.5 migration guide. Should that one be fixed as well in a separate PR?

@cweiske cweiske merged commit b3e7b16 into php:master Mar 23, 2026
2 checks passed
@cweiske
Copy link
Copy Markdown
Contributor

cweiske commented Mar 23, 2026

As mentioned in the PR description, I had originally placed it at the end following the pattern used in the PHP 8.5 migration guide. Should that one be fixed as well in a separate PR?

Feel free to do that.

@rodrigoprimo
Copy link
Copy Markdown
Contributor Author

rodrigoprimo commented Mar 23, 2026

Feel free to do that.

@cweiske, I just realized that #5437 was not merged yet, and there will be conflicts if I open another PR to update the order of the sections. I will wait until #5437 is merged, and then I will open another PR. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants