fix: reject content after table headers#5
Merged
dereuromark merged 1 commit intomasterfrom Mar 25, 2026
Merged
Conversation
TOML spec requires table headers to be "on a line by themselves". This rejects invalid syntax like `[table] key = "value"` while still allowing valid comments like `[table] # comment`. Added checkTableHeaderTerminator() method that validates table headers are followed only by newline, EOF, comment, or whitespace leading to those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TOML spec requires table headers to be "on a line by themselves". The parser was incorrectly accepting invalid syntax like:
This PR adds validation to reject content after table headers while still allowing valid comments:
Changes
checkTableHeaderTerminator()method that validates table headers are followed only by newline, EOF, comment, or whitespace leading to thoseTest Coverage
testDecodeRejectsContentAfterTableHeader- rejects[table] key = "value"testDecodeRejectsContentAfterArrayTableHeader- rejects[[array]] key = "value"testDecodeAcceptsCommentAfterTableHeader- accepts[table] # commenttestDecodeAcceptsWhitespaceBeforeCommentAfterTableHeader- accepts[table] # comment