Open
Conversation
Member
|
Does this actually work? I don't have a working version of the site to test it :) |
Author
Yes, it works!. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request implements a "No Album" virtual album feature that functions like OS X smart folders. When users have photos that aren't assigned to any album, a special "No Album" entry automatically appears in the Albums view, helping users discover and organize unorganized photos.
Related Issue
Resolves the need for better photo organization management when photos are uploaded without album assignment.
Type of change
✅ New feature (non-breaking change which adds functionality)
✅ Enhancement (improves existing functionality)
What's Changed
Backend Changes
DatabaseMySql.php: Added noalbum filter case and getNoAlbumPhotoCount() method
Album.php: Added getNoAlbumCount() method for counting unorganized photos
ApiAlbumController.php: Modified list_() and view() methods to handle virtual album
PhotoController.php: Added support for "noalbum" filter in photo listings
Frontend Changes
underscore.php: Updated album template to handle virtual album with special styling
Added conditional rendering for "No Album" with disabled edit/delete actions
Features Added
📁 Smart Virtual Album: Automatically appears only when unorganized photos exist
🔢 Photo Count: Shows exact number of photos without albums
🎨 Visual Design: Special styling to distinguish from regular albums
🚫 Protected Actions: Can't be edited or deleted (it's virtual)
🔗 Direct Access: Click to browse all unorganized photos at /photos/noalbum/list
Benefits
Photo Discovery: Users can easily find photos that need organization
Batch Management: Select multiple unorganized photos and assign to albums
Clean Interface: Only appears when needed, disappears when all photos are organized
User Experience: Encourages better photo organization habits
Testing
✅ Virtual album appears when photos without albums exist
✅ Virtual album disappears when all photos are organized
✅ Correct photo count display
✅ Browse functionality works correctly
✅ No edit/delete actions available for virtual album
✅ Proper routing for /photos/noalbum/list
Checklist:
✅ My changes are in a separate branch (add/feature-no-album-added)
✅ I have provided a detailed description of my changes
✅ I have linked any related issues
✅ Code follows existing patterns and architecture
✅ Feature is backward compatible
✅ No breaking changes introduced
au