chore: automate clean-up of attestations by Copilot · Pull Request #1200 · philips-software/amp-devcontainer

Copilot · 2026-03-13T13:29:59Z

Attestations were kept indefinitely even after their associated container images were removed. This extends both cleanup workflows to also delete attestations, keeping only those tied to active resources.

Changes

`image-cleanup.yml`

Three-phase pipeline where image deletion is leading:

collect-digests — snapshots all current package version digests per package before any cleanup (uploaded as artifacts)
cleanup-images — deletes images using ghcr-cleanup-action as before (if: always() ensures cleanup runs even if digest collection partially failed)
cleanup-attestations — downloads the snapshot, compares it to remaining digests after image cleanup, and deletes attestations only for digests that were actually removed

`pr-image-cleanup.yml`

Three-phase pipeline where image deletion is leading:

collect-pr-digests — resolves the pr-<N> tag to a digest per package and uploads as artifacts
delete-images — deletes the PR images first using ghcr-cleanup-action (if: always())
delete-attestations — deletes attestations for the PR digest collected in step 1, after the image is already gone

Retention decisions (what images to keep) are made entirely by ghcr-cleanup-action. Attestation cleanup is driven by what was actually deleted, with no duplicate tag-evaluation logic.

Original prompt

This section details on the original issue you should resolve

<issue_title>Automate clean-up of Attestations</issue_title>
<issue_description>## Current situation

Currently all generated attestations are kept indefinite, even when the resources that they point to are cleaned up.

Required situation

Extend the current clean up process to automatically clean up attestations. Keeping only the ones that point to active release or edge builds, as is specified in the acceptance criteria below.

Acceptance criteria

Attestations that don't point to a valid resource are cleaned up

Attestations from release branches are kept indefinite

Attestations for open pull requests are kept

Attestations for the last build on the default branch (tagged as edge) are kept</issue_description>

Comments on the Issue (you are Copilot in this section)

Fixes Automate clean-up of Attestations #1134

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

github-actions · 2026-03-13T13:35:56Z

✅⚠️MegaLinter analysis: Success with warnings

Descriptor	Linter	Files	Fixed	Errors	Warnings	Elapsed time
✅ ACTION	actionlint	23		0	0	0.27s
✅ DOCKERFILE	hadolint	3		0	0	0.28s
✅ JSON	npm-package-json-lint	yes		no	no	0.67s
✅ JSON	prettier	21	4	0	0	0.98s
✅ JSON	v8r	21		0	0	10.2s
✅ MARKDOWN	markdownlint	12	0	0	0	1.25s
✅ MARKDOWN	markdown-table-formatter	12	0	0	0	0.33s
✅ REPOSITORY	checkov	yes		no	no	25.15s
✅ REPOSITORY	gitleaks	yes		no	no	1.24s
✅ REPOSITORY	git_diff	yes		no	no	0.02s
✅ REPOSITORY	grype	yes		no	no	41.66s
✅ REPOSITORY	secretlint	yes		no	no	1.98s
✅ REPOSITORY	syft	yes		no	no	2.27s
✅ REPOSITORY	trivy	yes		no	no	11.05s
✅ REPOSITORY	trivy-sbom	yes		no	no	0.49s
✅ REPOSITORY	trufflehog	yes		no	no	6.31s
⚠️ SPELL	lychee	83		4	0	21.3s
✅ YAML	prettier	31	2	0	0	1.31s
✅ YAML	v8r	31		0	0	10.88s
✅ YAML	yamllint	31		0	0	1.05s

Detailed Issues

⚠️ SPELL / lychee - 4 errors

[IGNORED] docker://pandoc/extra:3.9.0.0-ubuntu@sha256:72afa9c8d3300e5f10c9c4330e101725687f2179bffd912fb859c6d2ae85de62 | Unsupported: Error creating request client: builder error for url (docker://pandoc/extra:3.9.0.0-ubuntu@sha256:72afa9c8d3300e5f10c9c4330e101725687f2179bffd912fb859c6d2ae85de62)
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden
[ERROR] https://slsa.dev/spec/v1.0/threats | Network error: error sending request for url (https://slsa.dev/spec/v1.0/threats) Maybe a certificate error?
[ERROR] https://www.contributor-covenant.org/version/2/0/code_of_conduct.html | Network error: error sending request for url (https://www.contributor-covenant.org/version/2/0/code_of_conduct.html) Maybe a certificate error?
[IGNORED] https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer | Unsupported: Error creating request client: builder error for url (vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/philips-software/amp-devcontainer)
[ERROR] https://opencontainers.org/ | Network error: error sending request for url (https://opencontainers.org/) Maybe a certificate error?
📝 Summary
---------------------
🔍 Total..........126
✅ Successful.....120
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........4

Errors in .github/CODE_OF_CONDUCT.md
[ERROR] https://www.contributor-covenant.org/version/2/0/code_of_conduct.html | Network error: error sending request for url (https://www.contributor-covenant.org/version/2/0/code_of_conduct.html) Maybe a certificate error?

Errors in .github/copilot-instructions.md
[ERROR] https://opencontainers.org/ | Network error: error sending request for url (https://opencontainers.org/) Maybe a certificate error?

Errors in test/cpp/features/security.feature
[ERROR] https://slsa.dev/spec/v1.0/threats | Network error: error sending request for url (https://slsa.dev/spec/v1.0/threats) Maybe a certificate error?

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads | Network error: Forbidden

See detailed reports in MegaLinter artifacts

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

oxsecurity/megalinter/flavors/salesforce@v9.4.0 (58 linters)
oxsecurity/megalinter/flavors/javascript@v9.4.0 (61 linters)

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

Documentation: Custom Flavors
Command: npx mega-linter-runner@9.4.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

Show us your support by starring ⭐ the repository

github-actions · 2026-03-13T13:36:19Z

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edge ➔ ghcr.io/philips-software/amp-devcontainer-base:pr-1200

📈 Size Comparison Table

OS/Platform	Previous	Current	Change	Trend
linux/amd64	145.22 MB	145.22 MB	1.31 kB (0%)	🔽
linux/arm64	137.54 MB	137.54 MB	272 B (0%)	🔽

github-actions · 2026-03-13T13:41:17Z

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edge ➔ ghcr.io/philips-software/amp-devcontainer-rust:pr-1200

📈 Size Comparison Table

OS/Platform	Previous	Current	Change	Trend
linux/amd64	455.71 MB	455.71 MB	1.35 kB (0%)	🔽
linux/arm64	408.89 MB	408.89 MB	+1.7 kB (+0%)	🔼

github-actions · 2026-03-13T13:42:59Z

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edge ➔ ghcr.io/philips-software/amp-devcontainer-cpp:pr-1200

📈 Size Comparison Table

OS/Platform	Previous	Current	Change	Trend
linux/amd64	544.28 MB	544.28 MB	930 B (0%)	🔽
linux/arm64	525.77 MB	525.77 MB	+142 B (+0%)	🔼

Co-authored-by: rjaegers <45816308+rjaegers@users.noreply.github.com>

Ron (rjaegers) · 2026-03-13T14:16:33Z

Copilot can we change the strategy to make image deletion leading, and then delete orphaned attestations? I don't like the detail and duplication of current approach. Also the attestation endpoint for deletion seems incorrect.

Co-authored-by: rjaegers <45816308+rjaegers@users.noreply.github.com>

Copilot · 2026-03-13T14:27:38Z

Copilot can we change the strategy to make image deletion leading, and then delete orphaned attestations? I don't like the detail and duplication of current approach. Also the attestation endpoint fo...

Refactored both workflows in commit 6419753 so image deletion is now leading:

image-cleanup.yml — 3-phase pipeline:

collect-digests — snapshots all current package digests before any cleanup (uploaded as artifacts)
cleanup-images — deletes images as before using ghcr-cleanup-action (if: always() ensures it always runs)
cleanup-attestations — downloads the snapshot, compares it to the remaining digests after cleanup, and only deletes attestations for digests that were actually removed

pr-image-cleanup.yml — same pattern:

collect-pr-digests — resolves the pr-<N> tag to a digest
delete-images — deletes the image first
delete-attestations — cleans up the attestation for the digest collected in step 1

This removes all the duplicate tag-evaluation logic — what images to keep is decided entirely by ghcr-cleanup-action, and attestation cleanup simply follows from what was actually deleted.

.github/workflows/image-cleanup.yml

.github/workflows/pr-image-cleanup.yml

github-actions · 2026-03-31T15:12:32Z

.github/workflows/pr-image-cleanup.yml

+    strategy:
+      fail-fast: false
+      matrix:
+        package: [amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]


[MegaLinter] _{reported by reviewdog 🐶}

Suggested change

package: [amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]

package:

[amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]

github-actions · 2026-03-31T15:17:17Z

Test Results

13 files ±0 13 suites ±0 19m 25s ⏱️ + 1m 0s
33 tests ±0 33 ✅ ±0 0 💤 ±0 0 ❌ ±0
137 runs ±0 137 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit df577b6. ± Comparison against base commit 0040519.

♻️ This comment has been updated with latest results.

github-actions · 2026-04-01T12:49:09Z

.github/workflows/image-cleanup.yml

+    strategy:
+      fail-fast: false
+      matrix:
+        package: [amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]


[MegaLinter] _{reported by reviewdog 🐶}

Suggested change

package: [amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]

package:

[amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]

github-actions · 2026-04-01T12:49:09Z

.github/workflows/image-cleanup.yml

+    strategy:
+      fail-fast: false
+      matrix:
+        package: [amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]


[MegaLinter] _{reported by reviewdog 🐶}

Suggested change

package: [amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]

package:

[amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]

sonarqubecloud · 2026-04-01T13:17:22Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-04-01T13:19:55Z

.github/workflows/pr-image-cleanup.yml

+    strategy:
+      fail-fast: false
+      matrix:
+        package: [amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]


[MegaLinter] _{reported by reviewdog 🐶}

Suggested change

package: [amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]

package:

[amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]

Initial plan

b531c69

Copilot AI assigned Copilot and Ron (rjaegers) Mar 13, 2026

Copilot started work on behalf of Ron (rjaegers) March 13, 2026 13:30 View session

Copilot AI temporarily deployed to acceptance-testing March 13, 2026 13:44 Inactive

Automate cleanup of attestations alongside image cleanup

bb9a228

Co-authored-by: rjaegers <45816308+rjaegers@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Automate clean-up of attestations~~ Automate clean-up of attestations Mar 13, 2026

Copilot AI requested a review from Ron (rjaegers) March 13, 2026 13:51

Copilot finished work on behalf of Ron (rjaegers) March 13, 2026 13:51

Copilot started work on behalf of Ron (rjaegers) March 13, 2026 14:16 View session

Refactor: make image deletion leading, then clean orphaned attestations

6419753

Co-authored-by: rjaegers <45816308+rjaegers@users.noreply.github.com>

Copilot finished work on behalf of Ron (rjaegers) March 13, 2026 14:28

Ron (rjaegers) changed the title ~~Automate clean-up of attestations~~ chore: automate clean-up of attestations Mar 31, 2026

Merge branch 'main' into copilot/automate-clean-up-attestations

9913f7d

github-advanced-security bot found potential problems Mar 31, 2026

View reviewed changes

github-actions bot reviewed Mar 31, 2026

View reviewed changes

ci: refactor attestation clean-up

b46a5f2

Ron (rjaegers) temporarily deployed to acceptance-testing April 1, 2026 12:16 — with GitHub Actions Inactive

ci: individual dry run selection

34fe70e

github-actions bot reviewed Apr 1, 2026

View reviewed changes

Ron (rjaegers) temporarily deployed to acceptance-testing April 1, 2026 12:57 — with GitHub Actions Inactive

ci: also update pr-image-cleanup

df577b6

github-actions bot reviewed Apr 1, 2026

View reviewed changes

Ron (rjaegers) temporarily deployed to acceptance-testing April 1, 2026 13:31 — with GitHub Actions Inactive

	package: [amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]
	package:
	[amp-devcontainer-base, amp-devcontainer-cpp, amp-devcontainer-rust]

Conversation

Copilot AI commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

image-cleanup.yml

pr-image-cleanup.yml

Required situation

Acceptance criteria

Comments on the Issue (you are Copilot in this section)

Uh oh!

github-actions bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅⚠️MegaLinter analysis: Success with warnings

Detailed Issues

Uh oh!

github-actions bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Container Size Analysis

📈 Size Comparison Table

Uh oh!

github-actions bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Container Size Analysis

📈 Size Comparison Table

Uh oh!

github-actions bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Container Size Analysis

📈 Size Comparison Table

Uh oh!

Ron (rjaegers) commented Mar 13, 2026

Uh oh!

Copilot AI commented Mar 13, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Apr 1, 2026

Quality Gate passed

Uh oh!

github-actions bot Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 13, 2026 •

edited

Loading

`image-cleanup.yml`

`pr-image-cleanup.yml`

github-actions bot commented Mar 13, 2026 •

edited

Loading

github-actions bot commented Mar 13, 2026 •

edited

Loading

github-actions bot commented Mar 13, 2026 •

edited

Loading

github-actions bot commented Mar 13, 2026 •

edited

Loading

github-actions bot commented Mar 31, 2026 •

edited

Loading