Security: Padding done right#33
Open
Opensourcecommunitydevelopment wants to merge 2 commits intopforemski:masterfrom
Open
Security: Padding done right#33Opensourcecommunitydevelopment wants to merge 2 commits intopforemski:masterfrom
Opensourcecommunitydevelopment wants to merge 2 commits intopforemski:masterfrom
Conversation
added 2 commits
July 31, 2017 23:43
API clients concerned about possible side-channel privacy attacks using the packet sizes of HTTPS GET requests can use this to make all requests exactly the same size by padding requests with random data. see pforemski#26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the current repeats the same char only by 500 times, No respect of actual query or Type length.. Making it pointless/guessable. While there is never a 500 chars domains according To RFC. Useless overhead.
API clients concerned about possible side-channel privacy attacks using the packet sizes of HTTPS GET requests can use this to make all requests exactly the same size by padding requests with random data.
see #26