Skip to content

Lang/rename to english - Full translation of comments and code.#98

Merged
petitlapin merged 1 commit intopetitlapin:mainfrom
0yech:lang/rename-to-english
Mar 26, 2026
Merged

Lang/rename to english - Full translation of comments and code.#98
petitlapin merged 1 commit intopetitlapin:mainfrom
0yech:lang/rename-to-english

Conversation

@0yech
Copy link
Copy Markdown
Contributor

@0yech 0yech commented Mar 24, 2026

Full English Translation + Variable/Code Renaming

Related issues : #59 #60

This PR provides a somewhat complete translation of the French elements present in Li-Ri's source code. The code logic remains untouched. Original French comments have been replaced with English equivalents, and variables with explicitly French names have been renamed to English counterparts.

Due to its nature, this PR is quite large. If it can't be merged you at least have all comments translated.

Comments are direct English translations to preserve their original intent.

Feedback on variable/code naming choices is very welcome.

@petitlapin
Copy link
Copy Markdown
Owner

Hi,

thanks for the PR! Was it done with AI or are you fluent in French/English?

I've started the checks to ensure if it is building / compliant with the formatting (it seems not for the second one).

It will take time to review (I think some comments are not needed at all, so it would be better to directly remove them instead of translating them for example) but it's really important to have the source translated in English if we want more contributors :).

@0yech
Copy link
Copy Markdown
Contributor Author

0yech commented Mar 24, 2026

Hello again, this was made by hand without AI. I am fluent in french, Ri-Li was a very popular game in primary school computers in Switzerland. Noticed the translation issues and thought it'd be great to get a good look at the entire project.

I didn't see the Formatting checks beforehand, I don't mind making necessary changes for it.

@petitlapin
Copy link
Copy Markdown
Owner

petitlapin commented Mar 24, 2026

Hello again, this was made by hand without AI. I am fluent in french, Ri-Li was a very popular game in primary school computers in Switzerland. Noticed the translation issues and thought it'd be great to get a good look at the entire project.

I didn't see the Formatting checks beforehand, I don't mind making necessary changes for it.

Thanks, I've just glanced through the changes and the quality looks good :). It will be complicated for me to take a deep look before next week. Would it be fine with you that you fix the issues raised in clang-tidy and clang-format, then I use your branch to directly push the comments I think should be removed? In the end, I'll squash and merge the PR with only one commit with you as author?

I think if I have to run on all the comments in the PR, then ask you to do the changes, it will take more time, it won't really be enjoyable for you to "just" remove comments, so it might be better to do it this way?

In all cases, thank you a lot for taking the time to do it!

edit: for the formatting, if you have clang-format in version 21 in your computer, it's only a matter of clang-format -i *.cc *.h to apply it. If you don't have this version, I can handle it, because it will boring to manually do the changes

@0yech
Copy link
Copy Markdown
Contributor Author

0yech commented Mar 24, 2026

Your idea is fine to me, I'll do the format changes needed, it's not a problem. I'll also clean up other things if I notice anything missing.

@petitlapin petitlapin force-pushed the lang/rename-to-english branch from ba8b652 to 5af8273 Compare March 26, 2026 17:18
Copy link
Copy Markdown
Owner

@petitlapin petitlapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you,
I've squashed the commits to only one with you as author.
We can merge once the build is green!

@zabidenhtf
Copy link
Copy Markdown
Contributor

Guys, here green flag
image

@0yech
Copy link
Copy Markdown
Contributor Author

0yech commented Mar 26, 2026

Awesome, thanks for reviewing all this

@petitlapin petitlapin merged commit 62c4d40 into petitlapin:main Mar 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants