Improved preserve_handlebar_syntax regex#270
Open
IwanBurg wants to merge 1 commit intopeterbe:masterfrom
Open
Conversation
a3491bf to
c98f319
Compare
c98f319 to
a2964b4
Compare
ronnievdc
reviewed
May 22, 2025
| out = re.sub( | ||
| r'="%7B%7B(.+?)%7D%7D"', | ||
| lambda match: '="{{' + unescape(unquote(match.groups()[0])) + '}}"', | ||
| r'="([^"]*)%7B%7B(.+?)%7D%7D([^"]*?)"', |
There was a problem hiding this comment.
To also support lxml version 5 (#297) , i propose the following change.
Suggested change
| r'="([^"]*)%7B%7B(.+?)%7D%7D([^"]*?)"', | |
| r'="([^"]*)(?:%7B%7B|{{)(.+?)(?:%7D%7D|}})([^"]*?)"', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
preserve_handlebar_syntax=True doesn't preserve handlebars with characters before or after the handlebars.
Examples of html that don't preserve handlebars:
a href="mailto:{{ Test }}"
a href="{{ Test }}?subject=x"
Current regex code:
Proposed regex code:
https://regex101.com/r/tLC41B/2
https://regex101.com/r/ADvQjO/1
Issue also here:
#271
I also added a testcase to test_premailer.py for:
a href="mailto:{{ data | default: "Test & code" }}?subject=x"
I'm new to this, so I hope this is how it works.