Fix stray ")" in global_indexstore path in generated BUILD.bazel#1090
Merged
ileitch merged 1 commit intoperipheryapp:masterfrom Mar 21, 2026
Merged
Conversation
The string interpolation on line 89 of BazelProjectDriver.swift has an
extra literal ")" after the Swift interpolation closure:
"\"\($0.makeAbsolute()))\""
The first "))" is: one ")" closing the interpolation \(...), and one
literal ")" that gets emitted into the BUILD.bazel file. This produces:
global_indexstore = "/path/to/indexstore)",
which is invalid Bazel syntax. Remove the stray ")".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BazelProjectDriver.swiftline 89 has an extra literal)in the string interpolation that constructs theglobal_indexstorevalue for the generatedBUILD.bazel:This produces invalid Bazel syntax in
/var/tmp/periphery_bazel/BUILD.bazel:instead of:
Fix
Remove the extra
)so the interpolation reads"\"\($0.makeAbsolute())\"".How to reproduce
Run periphery with
--bazel --bazel-index-store /any/pathand inspect the generated/var/tmp/periphery_bazel/BUILD.bazel— theglobal_indexstorevalue will contain a trailing)inside the quotes.