Honor exact Bazel filters without workspace-wide target discovery#1085
Open
meyers-oai wants to merge 1 commit intoperipheryapp:masterfrom
Open
Honor exact Bazel filters without workspace-wide target discovery#1085meyers-oai wants to merge 1 commit intoperipheryapp:masterfrom
meyers-oai wants to merge 1 commit intoperipheryapp:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Bazel mode, Periphery currently runs a broad target discovery query before applying --bazel-filter. That means even an exact label filter like //:app$ still requires the workspace to be bazel query //... clean. This breaks down in larger monorepos where a specific target is buildable, but unrelated packages fail to load during broad queries. For exact single-target label filters, Periphery does not need that discovery step.
This PR updates Periphery so that when --bazel-filter is an exact single-target label, it skips the broad discovery query and uses that label directly. More complex filters continue to behave as before.