Open
Conversation
| function setBaseURI(dom) { | ||
| let parsedURL; | ||
| try { | ||
| parsedURL = new URL(dom.baseURI); |
Contributor
There was a problem hiding this comment.
We should log some warning that we are skipping due to this issue, check same script how it's done for iframe outside body
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness of the iframe serialization logic by handling cases where an iframe's
baseURIis not a valid URL. It ensures that the code does not crash when encountering such cases and adds a test to verify this behavior.Error Handling Improvements:
setBaseURIinserialize-frames.jsto safely handle unparseablebaseURIvalues by wrapping theURLconstructor in a try/catch block and exiting early if parsing fails.Testing Enhancements:
serialize-frames.test.jsto ensure that serialization does not throw errors when an iframe has an invalidbaseURI, and that no<base>tag is injected in this scenario.