Minor change to avoid numpy DeprecationWarning#58
Minor change to avoid numpy DeprecationWarning#58oscgonfer wants to merge 1 commit intopegler:masterfrom
Conversation
| @@ -26,9 +26,11 @@ class are instantiated and queried directly | |||
| import numpy | |||
| WRAP = numpy.asarray | |||
There was a problem hiding this comment.
I think this would be cleaner if you did:
WRAP = functools.partial(numpy.asarray, dtype=object)
Then WRAP will always get the dtype=object argument, and you won't have to add or branch onnumpy_avail.
Although you will have to import functools. :-)
|
Bump on merging this? |
|
Hi! Note that with latest numpy 1.24.0rc0 this deprecation notice becomes an exception: |
|
As the repository is clearly not being maintained, maybe we should make a port and release it on pypi. Opinions? |
|
I don't want to hijack this PR, but I want to point out that my package timezonefinder offers the same functionality and is being actively maintained. If you are missing functionality, feel free to open an issue/PR there. Hope this helps. |
|
@jannikmi, thank you for the comment. I personally hadn't heard of your Long story short, switching to |
This is a minor PR to avoid numpy DeprecationWarning on: