add json files to MANIFEST.in, remove obsolete .csv file#46
Open
seahawk1986 wants to merge 1 commit intopegler:masterfrom
seahawk1986:fix_install
Open
add json files to MANIFEST.in, remove obsolete .csv file#46seahawk1986 wants to merge 1 commit intopegler:masterfrom seahawk1986:fix_install
seahawk1986 wants to merge 1 commit intopegler:masterfrom
seahawk1986:fix_install
Conversation
Contributor
|
Any news on when this will be merged? Should add a unit test @seahawk1986 to move his coverage up. Do a local read of the file and just check that it's a valid json. Note: This file is large; I'm going to do a pull request (starting from @seahawk1986 changes) and pickle/compress this file using standard lib, and have the load function decompress and load locally. I did the initial code, and the file size is reduced to 27 MB (compared to 90 MB). This would lighten the load of including the file in the pip install. |
linwoodc3
added a commit
to linwoodc3/pytzwhere
that referenced
this pull request
Aug 14, 2017
|
We need this fixed too. Please merge. Thank you! |
pegler
pushed a commit
that referenced
this pull request
Aug 22, 2017
famanson
pushed a commit
to esplorio/pytzwhere
that referenced
this pull request
Mar 5, 2019
* 'master' of https://github.com/pegler/pytzwhere: Update README to include example for forceTZ add worldtest.json.gz to manifest. bump version bump to 3.0.2 Reduces size of module bt 1/3. Achieves 94% code coverage, relating to pegler#8. Closes pegler#45. This is also an update to pegler#46 and @seahawks code to include the files on the MANIFEST file.. add json files to MANIFEST.in, remove obsolete .csv file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://setuptools.readthedocs.io/en/latest/setuptools.html?highlight=include_package_data#including-data-files all files that should be installed automatically when using
include_package_data=Truein setup.py must be included in the MANIFEST.inAlso
tzwhere/tz_world.csvhas been removed in df871d2This pull request should fix the installation of the missing json files reported in #44 and #45