Skip to content

feat: run on more events#343

Open
gardar wants to merge 2 commits intopatrickjahns:masterfrom
gardar:event-triggers
Open

feat: run on more events#343
gardar wants to merge 2 commits intopatrickjahns:masterfrom
gardar:event-triggers

Conversation

@gardar
Copy link
Copy Markdown

@gardar gardar commented Feb 16, 2023

Fixes: #341

@gardar
Copy link
Copy Markdown
Author

gardar commented Feb 17, 2023

Not sure if the failing CI is related to the change, thoughts @patrickjahns ?

@patrickjahns
Copy link
Copy Markdown
Owner

@gardar

Unfortunately it is the case - I've merged a couple of dependency PRs yesterday and the main branch is still green:
https://github.com/patrickjahns/version-drafter-action/actions/runs/4198960074/jobs/7283253356

Most likely it's an issue with https://github.com/release-drafter/release-drafter - maybe it's a well known issue and a fix is available upstream and you could bump the version used

On a different note - can you please share why the change is needed ? Why do you want to / need to run the action on different events than a push ( to main ) ?

Signed-off-by: gardar <gardar@users.noreply.github.com>
@gardar
Copy link
Copy Markdown
Author

gardar commented Feb 17, 2023

Ok rebased upstream, let's see if it fixes it.

In my case I want to be certain that the release workflow only runs upon successful merge to default branch and I don't want it to run if directly pushed to the default branch. But I see other use cases as well, for example if you only want to trigger a release workflow on workflow_dispatch, etc.

@gardar
Copy link
Copy Markdown
Author

gardar commented Feb 17, 2023

Ok so nope, sadly a simple rebase wasn't enough.

A quick google search for the error led me to this: release-drafter/release-drafter#578

@patrickjahns
Copy link
Copy Markdown
Owner

Most likely updating the dependency can work.
Tests cases should catch any issues.

If you want to allow more events, it would then be great to have at least 1-2 more tests cases covering anything besides a push scenario

@SuperQ
Copy link
Copy Markdown

SuperQ commented Mar 15, 2025

Ping, any chance this can move forward?

Signed-off-by: gardar <gardar@users.noreply.github.com>
@gardar
Copy link
Copy Markdown
Author

gardar commented Mar 16, 2025

@patrickjahns I added test cases for pull_request and workflow_dispatch events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to use action with merged pull request trigger

3 participants