Conversation
|
Not sure if the failing CI is related to the change, thoughts @patrickjahns ? |
|
Unfortunately it is the case - I've merged a couple of dependency PRs yesterday and the main branch is still green: Most likely it's an issue with https://github.com/release-drafter/release-drafter - maybe it's a well known issue and a fix is available upstream and you could bump the version used On a different note - can you please share why the change is needed ? Why do you want to / need to run the action on different events than a |
Signed-off-by: gardar <gardar@users.noreply.github.com>
2e8bc01 to
cf2fcf1
Compare
|
Ok rebased upstream, let's see if it fixes it. In my case I want to be certain that the release workflow only runs upon successful merge to default branch and I don't want it to run if directly pushed to the default branch. But I see other use cases as well, for example if you only want to trigger a release workflow on |
|
Ok so nope, sadly a simple rebase wasn't enough. A quick google search for the error led me to this: release-drafter/release-drafter#578 |
|
Most likely updating the dependency can work. If you want to allow more events, it would then be great to have at least 1-2 more tests cases covering anything besides a push scenario |
|
Ping, any chance this can move forward? |
Signed-off-by: gardar <gardar@users.noreply.github.com>
|
@patrickjahns I added test cases for pull_request and workflow_dispatch events |
Fixes: #341