Skip to content

Decouple cryptography, add extra property in Metadata#122

Merged
DavidBadura merged 2 commits into2.0.xfrom
decouple-cryptography
Nov 19, 2025
Merged

Decouple cryptography, add extra property in Metadata#122
DavidBadura merged 2 commits into2.0.xfrom
decouple-cryptography

Conversation

@DavidBadura
Copy link
Copy Markdown
Member

@DavidBadura DavidBadura commented Nov 18, 2025

The Cryptography feature has been further decoupled from the core. This was achieved by adding a property to ClassMetadata and PropertyMetadata to contain extra information. Enriching the metadata for Cryptography now happens in CryptographyMetadataFactory, which can then be wrapped around the AttributeMetadataFactory.

@DavidBadura DavidBadura changed the base branch from 1.12.x to 2.0.x November 18, 2025 11:43
@DavidBadura DavidBadura force-pushed the decouple-cryptography branch from 5c53fa3 to 4db999b Compare November 18, 2025 21:34
@github-actions
Copy link
Copy Markdown

github-actions bot commented Nov 18, 2025

Hello 👋

here is the most recent benchmark result:

HydratorWithCryptographyBench
=============================

+-------------------------------+------------------+-------------------+-----------------+------------+
|                               | time (kde mode)                      | memory                       |
+-------------------------------+------------------+-------------------+-----------------+------------+
| subject                       | Tag: <current>   | Tag: base         | Tag: <current>  | Tag: base  |
+-------------------------------+------------------+-------------------+-----------------+------------+
| benchHydrate1Object ()        | 5.000μs (±0.00%) | 5.600μs (±0.00%)  | 2.814mb         | 3.266mb    |
| benchExtract1Object ()        | 8.200μs (±0.00%) | 79.200μs (±0.00%) | 2.814mb         | 3.303mb    |
| benchHydrate1000Objects ()    | 3.923ms (±0.00%) | 3.942ms (±0.00%)  | 2.927mb         | 3.311mb    |
| benchExtract1000Objects ()    | 8.094ms (±0.00%) | 5.549ms (±0.00%)  | 2.915mb         | 3.396mb    |
| benchHydrate1000000Objects () | 2.300s (±0.00%)  | 2.252s (±0.00%)   | 2.927mb         | 3.311mb    |
| benchExtract1000000Objects () | 3.973s (±0.00%)  | 4.123s (±0.00%)   | 2.915mb         | 2.876mb    |
+-------------------------------+------------------+-------------------+-----------------+------------+

HydratorBench
=============

+-------------------------------+------------------+-------------------+-----------------+------------+
|                               | time (kde mode)                      | memory                       |
+-------------------------------+------------------+-------------------+-----------------+------------+
| subject                       | Tag: <current>   | Tag: base         | Tag: <current>  | Tag: base  |
+-------------------------------+------------------+-------------------+-----------------+------------+
| benchHydrate1Object ()        | 2.200μs (±0.00%) | 2.600μs (±0.00%)  | 2.763mb         | 2.763mb    |
| benchExtract1Object ()        | 3.000μs (±0.00%) | 66.600μs (±0.00%) | 2.763mb         | 2.763mb    |
| benchHydrate1000Objects ()    | 2.012ms (±0.00%) | 1.984ms (±0.00%)  | 2.823mb         | 2.824mb    |
| benchExtract1000Objects ()    | 1.868ms (±0.00%) | 1.874ms (±0.00%)  | 2.763mb         | 2.763mb    |
| benchHydrate1000000Objects () | 1.138s (±0.00%)  | 1.065s (±0.00%)   | 2.763mb         | 2.824mb    |
| benchExtract1000000Objects () | 1.222s (±0.00%)  | 1.234s (±0.00%)   | 2.763mb         | 2.763mb    |
+-------------------------------+------------------+-------------------+-----------------+------------+

HydratorWithLazyBench
=====================

+------------------------------------------+--------------------+--------------------+-----------------+------------+
|                                          | time (kde mode)                         | memory                       |
+------------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                  | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+------------------------------------------+--------------------+--------------------+-----------------+------------+
| benchHydrate1Object ()                   | 0.800μs (±0.00%)   | 0.600μs (±0.00%)   | 2.763mb         | 2.763mb    |
| benchHydrate1ObjectTriggerInit ()        | 3.200μs (±0.00%)   | 3.200μs (±0.00%)   | 2.763mb         | 2.763mb    |
| benchHydrate1000Objects ()               | 404.667μs (±0.00%) | 403.000μs (±0.00%) | 2.763mb         | 2.763mb    |
| benchHydrate1000ObjectsTriggerInit ()    | 2.893ms (±0.00%)   | 2.899ms (±0.00%)   | 2.834mb         | 2.834mb    |
| benchHydrate1000000Objects ()            | 262.912ms (±0.00%) | 262.234ms (±0.00%) | 2.763mb         | 2.763mb    |
| benchHydrate1000000ObjectsTriggerInit () | 2.016s (±0.00%)    | 2.030s (±0.00%)    | 2.834mb         | 2.834mb    |
+------------------------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the decouple-cryptography branch from 4db999b to 3f6b860 Compare November 19, 2025 12:17
@DavidBadura DavidBadura marked this pull request as ready for review November 19, 2025 12:23
@DavidBadura DavidBadura added this to the 2.0.0 milestone Nov 19, 2025
@DavidBadura DavidBadura changed the title Decouple cryptography Decouple cryptography, add extra property in Metadata Nov 19, 2025
@DavidBadura DavidBadura merged commit 400472f into 2.0.x Nov 19, 2025
13 of 15 checks passed
@DavidBadura DavidBadura deleted the decouple-cryptography branch November 19, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants