Fix ResultLogger dropping status and error fields#38
Merged
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
The _filter_report() method was only copying task_id and repeat_idx into filtered output, silently dropping the status and error fields. This made it impossible to distinguish successful runs from failures in persisted results. These are core metadata fields, not optional bulk data controlled by include_* flags.
fdc8897 to
b85377d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ResultLogger was only copying task_id and repeat_idx into filtered output, silently dropping the status and error fields. This made it hard to distinguish failures in persisted results. These are core metadata fields, not optional bulk data controlled by include_* flags.
Type of Change
Checklist
Contribution
Documentation
docs/(if applicable)Changelog
CHANGELOG.mdunder[Unreleased]sectionExample:
- Support for multi-agent tracing (PR:#123)Architecture (if applicable)
maseval/core/do NOT import frommaseval/interface/Additional Notes