Skip to content

Fix ResultLogger dropping status and error fields#38

Merged
cemde merged 2 commits intomainfrom
fix/result-logger-status-error
Mar 3, 2026
Merged

Fix ResultLogger dropping status and error fields#38
cemde merged 2 commits intomainfrom
fix/result-logger-status-error

Conversation

@cemde
Copy link
Collaborator

@cemde cemde commented Mar 3, 2026

Description

The ResultLogger was only copying task_id and repeat_idx into filtered output, silently dropping the status and error fields. This made it hard to distinguish failures in persisted results. These are core metadata fields, not optional bulk data controlled by include_* flags.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement (refactoring, formatting, etc.)

Checklist

Contribution

Documentation

  • Added/updated docstrings for new/modified functions as instructed CONTRIBUTING.md
  • Updated relevant documentation in docs/ (if applicable)
  • Tag github issue with this PR (if applicable)

Changelog

  • Added entry to CHANGELOG.md under [Unreleased] section
    • Use Added section for new features
    • Use Changed section for modifications to existing functionality
    • Use Fixed section for bug fixes
    • Use Removed section for deprecated/removed features
  • OR this is a documentation-only change (no changelog needed)

Example:
- Support for multi-agent tracing (PR:#123)

Architecture (if applicable)

  • Core/Interface separation: Changes in maseval/core/ do NOT import from maseval/interface/
  • Dependencies: New core dependencies added sparingly; framework integrations go to optional dependencies

Additional Notes

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  maseval/core
  benchmark.py
  maseval/core/callbacks
  result_logger.py
Project Total  

This report was generated by python-coverage-comment-action

The _filter_report() method was only copying task_id and repeat_idx into
filtered output, silently dropping the status and error fields. This made
it impossible to distinguish successful runs from failures in persisted
results. These are core metadata fields, not optional bulk data controlled
by include_* flags.
@cemde cemde force-pushed the fix/result-logger-status-error branch from fdc8897 to b85377d Compare March 3, 2026 15:13
@cemde cemde marked this pull request as ready for review March 3, 2026 15:26
@cemde cemde merged commit a4ec486 into main Mar 3, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant