feat: Add pan:delete command with ID-specific deletion and test case.#10
feat: Add pan:delete command with ID-specific deletion and test case.#10MrPunyapal merged 15 commits intopanphp:mainfrom
Conversation
taghwo
left a comment
taghwo
left a comment
There was a problem hiding this comment.
Nice work here, simple and clear 🚀
| <?php | ||
|
|
||
| beforeEach(function (): void { | ||
| $this->repository = mock(AnalyticsRepository::class)->makePartial(); |
There was a problem hiding this comment.
I like the test here, the way it's broken down.
What is the performance gain in using a mock versus hitting the DB here?
I would suggest hitting the DB and confirming the row is actually deleted or test the repository method in isolation.
There was a problem hiding this comment.
@ruchit288 can you assert the database is missing the ID after deleting in these tests instead of the mock? Another way would be, leave the command class test as it is, and have a separate test for the delete of method of the repository (assert database missing the ID deleted).
You can check the merged branches, look at the feature test cases on how you can insert some data into the table. That would even prevent hard coding the id like ['id' => 1]. You can use insertGetId, which would make the tests more stable and less prone to failure.
Co-authored-by: Taghwo Millionaire <40868373+taghwo@users.noreply.github.com>
Co-authored-by: Taghwo Millionaire <40868373+taghwo@users.noreply.github.com>
Merge updates.
Removed the intermediate variable for more concise code.
src/Adapters/Laravel/Repositories/DatabaseAnalyticsRepository.php
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
MrPunyapal
left a comment
MrPunyapal
left a comment
There was a problem hiding this comment.
I'll update needed tests locally
3 participants
This PR contain:
php artisan pan:delete 1