Merged
Conversation
This was referenced May 21, 2025
ChefMist
commented
May 21, 2025
.github/workflows/test.yml
Outdated
| uses: foundry-rs/foundry-toolchain@v1 | ||
| with: | ||
| version: nightly-471e4ac317858b3419faaee58ade30c0671021e0 # Nightly (2024-10-03) | ||
| version: v1.0.0 |
Contributor
Author
There was a problem hiding this comment.
open to v1.0.0 or if u guys prefer stable
Collaborator
There was a problem hiding this comment.
why use stable now ?
And test did not pass
Contributor
Author
There was a problem hiding this comment.
v1.0.0 timeout in CI for test, where v1.1.0 had performance optimization. see https://github.com/foundry-rs/foundry/releases/tag/v1.1.0
from CI test log can see our test runs much faster now
ChefSnoopy
previously approved these changes
May 21, 2025
ChefMist
changed the title
ChefSnoopy
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the required changes per foundry migration guide.