Properly cleanup SQLite persistence artifacts#97
Merged
viralpraxis merged 2 commits intopalkan:masterfrom Nov 7, 2025
Merged
Conversation
5ac0d06 to
09d8e59
Compare
CI errors are reproducible locally: ```bash $ env POSTGRES_URL=postgres://postgres:postgres@localhost:5432 DB=postgres BUNDLE_GEMFILE=gemfiles/rails8.gemfile bundle exec rspec <snip>/lib/active_record/connection_adapters/sqlite3/database_statements.rb:105:in 'SQLite3::Statement#step': SQLite3::IOException: disk I/O error (ActiveRecord::StatementInvalid) from <snip>/lib/active_record/connection_adapters/sqlite3/database_statements.rb:105:in 'ActiveRecord::ConnectionAdapters::SQLite3::DatabaseStatements#perform_query' from <snip>/lib/active_record/connection_adapters/abstract/database_statements.rb:571:in 'block (2 levels) in ActiveRecord::ConnectionAdapters::DatabaseStatements#raw_execute' from <snip>/lib/active_record/connection_adapters/abstract_adapter.rb:1081:in 'block in ActiveRecord::ConnectionAdapters::AbstractAdapter#with_raw_connection' from /home/viralpraxis/.asdf/installs/ruby/3.4.7/lib/ruby/gems/3.4.0/gems/activesupport-8.1.1/lib/active_support/concurrency/null_lock.rb:9:in 'ActiveSupport::Concurrency::NullLock#synchronize' from <snip>/lib/active_record/connection_adapters/abstract_adapter.rb:1050:in 'ActiveRecord::ConnectionAdapters::AbstractAdapter#with_raw_connection' from <snip>/lib/active_record/connection_adapters/abstract/database_statements.rb:570:in 'block in ActiveRecord::ConnectionAdapters::DatabaseStatements#raw_execute' ``` I have no idea what changed on the SQLite's side but seems like we have to cleanup WAL and shared-memory files: ```shell $ ls tmp testdb2 testdb2-shm testdb2-wal ``` ```shell $ sqlite3 --version 3.51.0 2025-11-04 19:38:17 fb2c931ae597f8d00a37574ff67aeed3eced4e5547f9120744a-experimental (64-bit) ```
This reverts commit 5f815be.
09d8e59 to
0cc5f32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI errors are reproducible locally:
I have no idea what changed on the SQLite's side but seems like we have to cleanup WAL and shared-memory files: