feat: [IEL-186] Expired document in blob storage case#583
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the FCI dev-server endpoints to better simulate production-like expiring document URLs and blob-storage-style expiration failures during the digital signature flow.
Changes:
- Adds an
expirationquery parameter to FCI document URLs returned by the signature request detail endpoint. - Introduces an expiration check on the static PDF serving endpoint, returning a 403 XML error similar to Azure Blob Storage when expired.
- Extends the messages FCI config schema/defaults with
documentExpirationDurationSeconds.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/routers/features/fci/index.ts |
Appends an expiration timestamp to document URLs and simulates blob-style 403 responses for expired downloads. |
src/features/messages/types/messagesConfig.ts |
Adds documentExpirationDurationSeconds to the io-ts config type for FCI responses. |
src/config.ts |
Provides a default value for documentExpirationDurationSeconds in the dev-server default config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
When entering the digital signature flow the list of pdf documents are reuqested and obtained as urls with expiration to download them.
This PR aims to replicate that aspect.
List of changes proposed in this pull request
How to test