Skip to content

feat: [IEL-186] Expired document in blob storage case#583

Merged
Ladirico merged 3 commits intomasterfrom
IEL-186-fci-docuemnts-expiration
Mar 23, 2026
Merged

feat: [IEL-186] Expired document in blob storage case#583
Ladirico merged 3 commits intomasterfrom
IEL-186-fci-docuemnts-expiration

Conversation

@freddi301
Copy link
Copy Markdown
Collaborator

@freddi301 freddi301 commented Mar 17, 2026

Short description

When entering the digital signature flow the list of pdf documents are reuqested and obtained as urls with expiration to download them.
This PR aims to replicate that aspect.

List of changes proposed in this pull request

  • add an expiration url query parameter to mimic document urls with expiration like in production
  • check for expiration when getting document pdf file, simulate blob storage response

How to test

  • start developer server
  • start app pointing to developer server
  • in the app complete an "firma con io" signature requets under 5 minutes, it should go fine
  • second case, wait 5 minutes after opening a signature request, expected effects
    • pdf documents will not load corectly if navigating in the flow
    • you can't submit a signature correctly in the final step (error screen show on the last CTA)

@freddi301 freddi301 self-assigned this Mar 17, 2026
@freddi301 freddi301 marked this pull request as ready for review March 17, 2026 16:25
@freddi301 freddi301 requested review from a team, ChrisMattew, gispada and soixdev91 as code owners March 17, 2026 16:25
@Ladirico Ladirico requested a review from Copilot March 19, 2026 08:29

This comment was marked as outdated.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the FCI dev-server endpoints to better simulate production-like expiring document URLs and blob-storage-style expiration failures during the digital signature flow.

Changes:

  • Adds an expiration query parameter to FCI document URLs returned by the signature request detail endpoint.
  • Introduces an expiration check on the static PDF serving endpoint, returning a 403 XML error similar to Azure Blob Storage when expired.
  • Extends the messages FCI config schema/defaults with documentExpirationDurationSeconds.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/routers/features/fci/index.ts Appends an expiration timestamp to document URLs and simulates blob-style 403 responses for expired downloads.
src/features/messages/types/messagesConfig.ts Adds documentExpirationDurationSeconds to the io-ts config type for FCI responses.
src/config.ts Provides a default value for documentExpirationDurationSeconds in the dev-server default config.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@Ladirico Ladirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ladirico Ladirico merged commit 42b8487 into master Mar 23, 2026
5 checks passed
@Ladirico Ladirico deleted the IEL-186-fci-docuemnts-expiration branch March 23, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants