chore(IT-Wallet): [SIW-4062] Add mtc tracking#7948
Draft
DavideOnano wants to merge 12 commits intoSIW-4022/feat-bottomsheet-mdl-expired-invalidfrom
Draft
chore(IT-Wallet): [SIW-4062] Add mtc tracking#7948DavideOnano wants to merge 12 commits intoSIW-4022/feat-bottomsheet-mdl-expired-invalidfrom
DavideOnano wants to merge 12 commits intoSIW-4022/feat-bottomsheet-mdl-expired-invalidfrom
Conversation
## Short description During the review of this [development](#7914), I noticed some alignment issues in a few bottom sheets. This problem is also present in the master branch. This pull request introduces minor adjustments to the layout spacing in the App Feedback and IDPay static code modal components, improving visual alignment and ensuring greater layout consistency. ## List of changes proposed in this pull request - Added a `VSpacer` of size 32 above the Android-specific spacer in the `AppFeedbackProvider` component to improve separation between elements - Adjust spacing in the `useIDPayStaticCodeModal` hook - Adjust `IOText` color based on theme color ## How to test Ensure that element inside related bottom-sheet have correct spacing. To test `AppFeedbackProvider` bottom-sheet, you can call the `present` method before rendering component ## Preview | Master | IOPLT-000 | |--------|--------| | <img width="1728" height="1117" alt="Screenshot 2026-03-10 at 12 26 45" src="https://github.com/user-attachments/assets/b74176bf-ca4e-48b4-bb9a-d5af0f2556a7" /> | <img width="1728" height="1117" alt="Screenshot 2026-03-10 at 12 26 24" src="https://github.com/user-attachments/assets/3109ef21-95f2-4998-a964-09b7864d0d36" />| | <img width="1728" height="1117" alt="Screenshot 2026-03-10 at 12 29 51" src="https://github.com/user-attachments/assets/6b1c48fb-9dd0-4ea0-b481-ab18c4c24213" /> | <img width="1728" height="1117" alt="Screenshot 2026-03-10 at 12 29 33" src="https://github.com/user-attachments/assets/fe5679cf-d742-46a5-9f3c-a3c9d6487400" />|
## Short description --- 🔴 DEPENDS ON #7880 🔴 --- this PR introduces the logic required to display the correct error screens in case of a TTL error in both the mandate creation and mandate validation steps of the AAR delegation flow | mandate validation | mandate creation | |--------|--------| |<img width="250" alt="Screenshot 2026-02-26 at 15 27 54" src="https://github.com/user-attachments/assets/9c8b93e1-7234-4c41-a700-bbe4c16be245" />|<img width="250" alt="Screenshot 2026-02-26 at 15 30 32" src="https://github.com/user-attachments/assets/e4e7f46c-ecdd-4868-8126-e14260bf2202" />| ## List of changes proposed in this pull request - added required components - added required i18n entries - refactored the error handling logic to accomodate for the new components - tests ## How to test - automated tests should pass. - make sure the pre-implemented error screens in the AAR flow behave and display as expected Also, using either the dev-server or proxy software (e.g. proxyman): - a 500 error in the mandate creation response with {code:`PN_MANDATE_ALREADYEXISTS`} as the first entry in the `errors` array should result in its specific error screen. no other configuration (e.g. different http code, different error as the first entry) should result in the same screen. - a 500 error in the mandate validation response with {code: `PN_MANDATE_NOTFOUND`} as its first entry in the `errors` array should behave the same way as the mandate creation response logic. --------- Co-authored-by: Andrea <andrea.piai@pagopa.it>
## Short description 🔴 DEPENDS ON #7897 This PR includes tracking functions for the SEND AAR TTL errors ## List of changes proposed in this pull request - added tracking functions - updated current flows to call said functions when needed - updated tests ## How to test automated tests should pass. also, using the dev-server, verify that all new tracking functions are called when expected, and their effects match the ones mapped in their corresponding documents. --------- Co-authored-by: Andrea <andrea.piai@pagopa.it>
…capture (#7840) > [!note] > This PR requires to elevate min **iOS** version to `15.1` ## Short description This PR installs expo and fixes related dependencies to build on both iOS and Android. Furthermore in this PR the first expo-module has been installed, replacing previous react-native module. `expo-screen-capture` takes place of `react-native-screenshot-prevent` removing the related references and patch. ## List of changes proposed in this pull request - Installs `expo` - Removes unsupported and unused dependencies - Disables the auto-linking on local env for `@pagopa/react-native-cie` on **iOS** - Replaces `react-native-screenshot-prevent` with `expo-screen-capture` ## How to test To test the PR follow these steps: - Remove `node_modules` runninng `rm -rf node_modules` - Remove Pods and derived data running `cd ios; rm -rf Pods; rm -rf DerivedData` - Run complete new installation of packages with `yarn install` - Run new pod installation command with `yarn dev:pod-install` - Build and compile iOS and Android project to check anything's working as usual
## Short description This pull request updates the version of the IO Session Manager dependency ## List of changes proposed in this pull request - Bumped `IO_SESSION_MANAGER_VERSION` from `1.8.0` to `1.23.1` ## How to test - Ensure the app works with no regression - Ensure that `yarn tsc:noemit` is running without errors
DavideOnano
changed the title
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
DavideOnano
changed the title
DavideOnano
changed the base branch from
master
to
SIW-4022/feat-bottomsheet-mdl-expired-invalid
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## SIW-4022/feat-bottomsheet-mdl-expired-invalid #7948 +/- ##
=================================================================================
+ Coverage 60.24% 60.29% +0.04%
=================================================================================
Files 1968 1968
Lines 43941 43969 +28
Branches 10147 10074 -73
=================================================================================
+ Hits 26474 26510 +36
- Misses 17378 17380 +2
+ Partials 89 79 -10
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review first #7942 in order to avoid duplicate review work.
Short description
Include a summary of the changes.
List of changes proposed in this pull request
How to test
Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.