Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions .github/workflows/claude-review.yml
Original file line number Diff line number Diff line change
@@ -1,28 +1,24 @@
name: Claude Code Review

on:
pull_request:
types: [opened, ready_for_review, synchronize]
merge_group:
types: [checks_requested]
push:
branches:
- gh-readonly-queue/**
merge_group: {}

permissions:
contents: read
id-token: write
pull-requests: write

concurrency:
group: claude-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
claude-review:
name: claude-review
runs-on: ubuntu-latest
steps:
- name: Skip in merge queue context
if: github.event_name == 'merge_group'
run: echo "Skipping AI PR review in merge queue context."
- name: Skip on queue refs
if: github.event_name == 'merge_group' || github.event_name == 'push'
run: echo "Skipping review in queue context"
- name: Run claude review
if: github.event_name == 'pull_request' && github.event.pull_request.draft == false
continue-on-error: true
Expand Down
20 changes: 7 additions & 13 deletions .github/workflows/codex-review.yml
Original file line number Diff line number Diff line change
@@ -1,32 +1,26 @@
name: Codex Code Review

on:
pull_request:
types: [opened, ready_for_review, synchronize]
merge_group:
types: [checks_requested]
push:
branches:
- gh-readonly-queue/**
merge_group: {}

permissions:
contents: read
id-token: write
issues: write
pull-requests: write

concurrency:
group: codex-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

jobs:
codex-review:
name: codex-review
runs-on: ubuntu-latest
steps:
- name: Skip in merge queue context
if: github.event_name == 'merge_group'
run: echo "Skipping AI PR review in merge queue context."
- name: Skip on queue refs
if: github.event_name == 'merge_group' || github.event_name == 'push'
run: echo "Skipping review in queue context"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 [P1] .github/workflows/codex-review.yml:22 codex review no longer marked optional

Current code:

      - name: Run codex review
        if: github.event_name == 'pull_request' && github.event.pull_request.draft == false && github.event.pull_request.head.repo.fork == false
        uses: p6m7g8-actions/codex@main

Problem: Action failures now fail the workflow, blocking merges when the Codex service or secret is unavailable.

Fix:

      - name: Run codex review
        if: github.event_name == 'pull_request' && github.event.pull_request.draft == false && github.event.pull_request.head.repo.fork == false
        continue-on-error: true
        uses: p6m7g8-actions/codex@main

- name: Run codex review
if: github.event_name == 'pull_request' && github.event.pull_request.draft == false && github.event.pull_request.head.repo.fork == false
continue-on-error: true
uses: p6m7g8-actions/codex@main
with:
openai_api_key: ${{ secrets.OPENAI_API_KEY }}
8 changes: 8 additions & 0 deletions .github/workflows/pull-request-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
- reopened
- ready_for_review
- edited
push:
branches:
- gh-readonly-queue/**
merge_group: {}

jobs:
lint:
Expand All @@ -17,7 +21,11 @@ jobs:
permissions:
pull-requests: read
steps:
- name: Skip on queue refs
if: github.event_name == 'merge_group' || github.event_name == 'push'
run: echo "Skipping lint in queue context"
- name: Lint PR title
if: github.event_name == 'pull_request_target'
uses: p6m7g8-actions/p6-gh-pr-title-linter@main
with:
gh_token: ${{ secrets.GITHUB_TOKEN }}
Loading