Levon/make bgp dispatch listen configurable#654
Open
internet-diglett wants to merge 7 commits intomainfrom
Open
Levon/make bgp dispatch listen configurable#654internet-diglett wants to merge 7 commits intomainfrom
internet-diglett wants to merge 7 commits intomainfrom
Conversation
We'd like the ability to create a topology of BGP routers in our test and dev tooling. To do so with the current omicron-dev and testing contexts, we need the peering to occur over localhost, which means we need to be able to configure unique localhost socketaddrs for each instance.
The omicron dev and test contexts provide :0 as the listen port and rely on the log messages to output the actual port number that the daemon bound to.
taspelund
requested changes
Mar 4, 2026
Contributor
taspelund
left a comment
taspelund
left a comment
There was a problem hiding this comment.
Looks good overall. If you wouldn't mind using the preexisting logging macros that wrap slog, that would be great. Otherwise, LGTM!
taspelund
approved these changes
Mar 9, 2026
In testing environments we commonly communicate over local addresses. Previously, maghemite relied on the OS to select the source ip address for peering requests. This can create problems in testing because the host will pick the same source address as the the target peer address, causing the peer to reject the bgp peering session. By allowing explicit configuration of the source address we resolve this issue.
Contributor
|
Overall this looks good to me. The only thing I have some concern about is the lack of validation that the address-family of the Source IP matches the address-family of the peer's IP (matching the variant inside PeerId::Ip or v6 for PeerId::Interface). I imagine that logic could live in Once that's done and the PR has been rebased, I think we're good to go |
internet-diglett
added a commit
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.