Log PWM sensor types in humility dashboard#602
Merged
Conversation
labbott
approved these changes
Mar 11, 2026
hawkw
approved these changes
Mar 11, 2026
Member
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
sure, seems good!
it would maybe be nice to also show them in the TUI?
Contributor
Author
|
Yeah, I didn't want to touch the graph code in this PR, but we could do that at some point in the future! |
mkeeter
added a commit
to oxidecomputer/hubris
that referenced
this pull request
Mar 13, 2026
This adds a new `fan_ctrl` sensor, which is updated by the thermal loop. In combination with oxidecomputer/humility#602, we can log both fan speed (which was already possible) and commanded PWM values with `humility dashboard -o out.csv`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a building block for examining thermal loop performance.
They aren't shown on the screen, but are logged to the CSV file.