This repository was archived by the owner on Jul 4, 2023. It is now read-only.
Fix statx_timestamp types/field names#1
Merged
oxalica merged 3 commits intooxalica:masterfrom Oct 3, 2019
Merged
Conversation
oxalica
approved these changes
Oct 3, 2019
Owner
|
Thanks! But since |
Contributor
Author
|
Right I guess I can do the syscall with libc too, I’ll check that. |
Owner
|
I make this crate compatible to libc 0.2.3 , as fallback for system with I think this may still be helpful for std. |
Contributor
Author
|
The standard library is using libc, too. The problem is that they made the very dumb choice of exposing the underlying type by creating the By the way, my exa PR is here (since I mentioned it but didn’t put a link). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tv_nsecwas namedtc_nsecstatx_timestamp.__reservedwhich stays ani32— like in Linux headers — instead of an[i32; 1]like the glibc)I implemented getting created time on Linux in exa with your crate (thanks!), I’ll just wait for this PR to be merged so I can use the correct field name right away. :)