Open
Conversation
NiklasEi
commented
Mar 20, 2026
Author
NiklasEi
left a comment
NiklasEi
left a comment
There was a problem hiding this comment.
Most of the changes outside of the two new files are due to the version bump of rand.
| [target.'cfg(target_arch = "wasm32")'.dependencies] | ||
| getrandom = { version = "0.2", features = ["js"] } | ||
| getrandom_04 = { package = "getrandom", version = "0.4", features = ["wasm_js"] } | ||
| getrandom_02 = { package = "getrandom", version = "0.2", features = ["js"] } |
Author
There was a problem hiding this comment.
I couldn't get rid of this version as transitive dependency and the WASM project doesn't build without the js feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a best effort attempt at supporting format and regex for fuzzing (this was blocking my use-case).
For regex, we walk
fancy_regex::ExprAST and fall back onregex-syntaxHIR for character classes.For format I use the
fakecrate where possible.Implementing those two removed a couple of whitelisted test failures.