Open
Conversation
making hex color parsing optional checking input length before checking char[0]
|
I just found this PR because I need the exact same thing: externally-defined color variables in a white labeled application. This would be great! |
|
@sugaaloop for now you could use this: https://github.com/giowe/gulp-sass-vars - it would be simple to export a JS object from a file so that you could dynamically set your variables. |
Author
|
@squatto i'm currently using my "fork". gulp-sass-vars is using parse-sass-value, which looks like exactly what we're looking for. i might check it out, but for now this PR is working well enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Not sure if you have any interest, I came across a use case for adding colors dynamically from gulp into sass (white-labeling an application) and wanted to see what you thoughts were for injecting hex colors. I needed the colors available in both sass and javascript and didn't want to define them twice.
I know it's a little hacky, but I couldn't think of a cleaner way to identify a hex color in JS.