Skip to content

Revert "MGMT-23354: Add archived variable to common repository module (#53)"#56

Closed
jhernand wants to merge 1 commit intoosac-project:mainfrom
jhernand:revert_change_to_add_archived_repo_support
Closed

Revert "MGMT-23354: Add archived variable to common repository module (#53)"#56
jhernand wants to merge 1 commit intoosac-project:mainfrom
jhernand:revert_change_to_add_archived_repo_support

Conversation

@jhernand
Copy link
Copy Markdown
Contributor

@jhernand jhernand commented Mar 5, 2026

This reverts commit 1a1e151.

@larsks larsks force-pushed the revert_change_to_add_archived_repo_support branch from 4405ba2 to 2626f4b Compare March 5, 2026 18:20
@larsks
Copy link
Copy Markdown
Member

larsks commented Mar 5, 2026

The original change adding support for the archive attribute seems at first glance like a reasonable change. I'm going to run a couple of experiments with it just to better understand the failure.

@larsks
Copy link
Copy Markdown
Member

larsks commented Mar 5, 2026

I'm inclined to keep the original changes. I was able to successfully archive the archive-test repository (https://github.com/osac-project/archive-test) using your changes, and it didn't seem to cause any problems. The problem cropped up because opentofu was attempting to manage other attributes on the repositories after they had been archived, but I think that is a side effect of prow managing the same repos. I think the long term fix is to make it possible to exempt some repo attributes from being managed by this tooling.

@jhernand
Copy link
Copy Markdown
Contributor Author

jhernand commented Mar 5, 2026

I'm inclined to keep the original changes.

No objection, I am closing this pull request.

@jhernand jhernand closed this Mar 5, 2026
@jhernand jhernand deleted the revert_change_to_add_archived_repo_support branch March 5, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants