docs(patch): fix stale NaN semantics documentation after signalling change#5
Merged
docs(patch): fix stale NaN semantics documentation after signalling change#5
Conversation
The NaN implementation was changed to signalling in 786e963 but several documentation files still described the old quiet (propagating) behavior. - README: fix NaN example and fuzz testing description - TypeDesign.md: correct NaN semantics bullet from "propagates" to "traps" - GettingStarted.md: rewrite NaN section for trapping semantics - FixedPointDecimal.swift: fix pow() doc comment precondition Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hassila
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 28 28
Lines 3840 3840
=======================================
Hits 3787 3787
Misses 53 53
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
hassila
changed the title
|
Pull request had an unknown failure |
jhansbo
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pow()doc comment to correctly describe trapping semanticsChanges
README.mdTypeDesign.mdGettingStarted.mdFixedPointDecimal.swiftpow()doc: "Returns .nan" → precondition documentationTest plan
swift buildcompiles cleanly (docs-only change)🤖 Generated with Claude Code