fix: remove polyfills from the library#1141
Open
matinzd wants to merge 1 commit intooptimizely:masterfrom
Open
fix: remove polyfills from the library#1141matinzd wants to merge 1 commit intooptimizely:masterfrom
matinzd wants to merge 1 commit intooptimizely:masterfrom
Conversation
Removed unused imports for fast-text-encoding and react-native-get-random-values.
matinzd
changed the title
junaed-optimizely
requested changes
Mar 27, 2026
Comment on lines
-16
to
-18
| import 'fast-text-encoding'; | ||
| import 'react-native-get-random-values'; | ||
|
|
Contributor
There was a problem hiding this comment.
I agree users should be able to bring their own polyfills, but removing these imports outright would be a breaking change.
A better approach for the current version would be conditional imports (similar to how we handle @react-native-async-storage/async-storage) - check if the globals already exist before requiring the polyfill packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing two import statements that are no not needed. Polyfills should be imported/configured by the user in their project. Some people might want to use https://github.com/margelo/react-native-quick-crypto
/cc @mrousavy