bundle version increased type safety / serialization support#1938
bundle version increased type safety / serialization support#1938grokspawn wants to merge 3 commits intooperator-framework:masterfrom
Conversation
Signed-off-by: grokspawn <jordan@nimblewidget.com>
|
Skipping CI for Draft Pull Request. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1938 +/- ##
==========================================
+ Coverage 57.50% 57.74% +0.24%
==========================================
Files 139 139
Lines 13339 13382 +43
==========================================
+ Hits 7671 7728 +57
+ Misses 4486 4468 -18
- Partials 1182 1186 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: grokspawn <jordan@nimblewidget.com>
9df00dd to
6121538
Compare
alpha/declcfg/declcfg.go
Outdated
|
|
||
| // Validate against CRD constraint from operators.coreos.com/v1alpha1 ClusterServiceVersion | ||
| // Maximum length of 20 characters | ||
| if len(relStr) > 20 { |
There was a problem hiding this comment.
Is there a value we can get that isn't a magic number?
There was a problem hiding this comment.
There isn't one defined presently, but I'm happy to define a constant here for it. The reference is in the type here, but we're deliberately not using that type in this repo (to de-couple v0 & v1 uses), so we just need to be consistent.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: grokspawn <jordan@nimblewidget.com>
Description of the change:
This is a deliberate re-scoping of the CompositeVersion type to co-locate all the bits of dependency on use of the underlying blang semver PRVersion slice, by making this an explicit type.
The original implementation was evaluating the tradeoffs between re-use of the semver.Parse method versus re-implementing just the semver.org pre-release version info for validation.
api-diff is intended to fail here, and will need to be overridden (since we are un-exporting the fields to make this an opaque type).
Motivation for the change:
Reviewer Checklist
/docs