render package-level info from channel head in semver template#1933
Conversation
Signed-off-by: grokspawn <jordan@nimblewidget.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1933 +/- ##
==========================================
+ Coverage 57.52% 57.67% +0.15%
==========================================
Files 139 139
Lines 13339 13363 +24
==========================================
+ Hits 7673 7707 +34
+ Misses 4484 4469 -15
- Partials 1182 1187 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
grokspawn
force-pushed
the
semver-package-info
branch
from
77032b4 to
ea21fb2
Compare
alpha/template/semver/semver.go
Outdated
| // Parse CSV JSON to extract metadata | ||
| var csv registry.ClusterServiceVersion | ||
| if err := json.Unmarshal([]byte(cfg.Bundles[bundleIdx].CsvJSON), &csv); err != nil { | ||
| return fmt.Errorf("unmarshal CSV JSON for bundle %q: %v", cfg.Bundles[bundleIdx].Name, err) |
There was a problem hiding this comment.
This is the only error return, and I'm pretty confident we could eliminate this since at this point all the schema content should be validated already. Then this function could be more consistent with what I believe is a reasonable expectation that the package info is only provided in olm.package if it is provided in olm.bundle.
We could do an exhaustive check to ensure that we've "bubbled up" any reasonable data to fill vacancies, but that seems excessive.
There was a problem hiding this comment.
Made the update to eliminate the error return, since it doesn't make sense to have to RE-verify the schema anew here.
grokspawn
force-pushed
the
semver-package-info
branch
from
ea21fb2 to
acfc4db
Compare
grokspawn
force-pushed
the
semver-package-info
branch
from
acfc4db to
64b4ed7
Compare
|
/approve |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 2095729
into
operator-framework:master
4 participants
Description of the change:
when expanding semver catalog templates, pulls the package info for generated FBC from the default channel head bundle, solving #1837
Motivation for the change:
Reviewer Checklist
/docs