OPRUN-4519: block upgrades from 4.23 to 5.0#3803
Open
fgiudici wants to merge 2 commits intooperator-framework:masterfrom
Open
OPRUN-4519: block upgrades from 4.23 to 5.0#3803fgiudici wants to merge 2 commits intooperator-framework:masterfrom
fgiudici wants to merge 2 commits intooperator-framework:masterfrom
Conversation
OCP 4.23 and 5.0 represent the same release. Add normalizeOCPVersion() to map 4.23 to 5.0 before computing the next Y-stream and comparing an operator's declared max version, so both cluster and operator versions are evaluated consistently. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Francesco Giudici <fgiudici@redhat.com>
Cover cluster versions 4.22, 4.23, 5.0, and 5.1 against operators declaring maxOpenShiftVersion 4.23, 5.0, and 5.1. Add TestNormalizeOCPVersion for the new helper. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Francesco Giudici <fgiudici@redhat.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCP 4.23 and 5.0 represent the same release.
Add normalizeOCPVersion() to map 4.23 to 5.0 before computing the next Y-stream and comparing an operator's declared max version, so both cluster and operator versions are evaluated consistently.
Add test coverage for 4.23/5.0 upgrades.
Co-authored-by: Claude Sonnet 4.6 noreply@anthropic.com
Signed-off-by: Francesco Giudici fgiudici@redhat.com
Description of the change:
Motivation for the change:
Architectural changes:
Testing remarks:
Reviewer Checklist
/doc[FLAKE]are truly flaky and have an issueOPRUN-4519