refactor(constraint): update none compound constraint to be not#221
Merged
awgreene merged 1 commit intooperator-framework:masterfrom Jan 26, 2022
Merged
Conversation
tylerslaton
added
the
do-not-merge/work-in-progress
Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
tylerslaton
force-pushed
the
none-to-not-constraint
branch
from
d9e657c to
844646c
Compare
tylerslaton
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, tylerslaton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Contributor
Author
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
Contributor
Author
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
Member
|
/lgtm |
timflannagan
pushed a commit
to timflannagan/of-api
that referenced
this pull request
Jan 27, 2022
…ator-framework#221) Signed-off-by: Tyler Slaton <tyslaton@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Slaton tyslaton@redhat.com
Summary
Updating this code to fit the new recent changes to the compound constraints EP in an effort to make this UX clearer. This PR simple updates the code to reference
notinstead ofnone.