fwupd: update to latest/2.1.1 release#28914
Open
ma-neumann wants to merge 1 commit intoopenwrt:masterfrom
Open
fwupd: update to latest/2.1.1 release#28914ma-neumann wants to merge 1 commit intoopenwrt:masterfrom
ma-neumann wants to merge 1 commit intoopenwrt:masterfrom
Conversation
lvoegl
suggested changes
Mar 19, 2026
utils/fwupd/Makefile
Outdated
| -Dlvfs=$(if $(CONFIG_FWUPD_LVFS),true,false) \ | ||
| -Dman=false \ | ||
| -Dmetainfo=false \ | ||
| -Dudev_hotplug=true \ |
Contributor
There was a problem hiding this comment.
There is no udev in OpenWrt. If udev_hotplug=false, fwupd uses the kernel's netlink hotplug socket directly, which is what we want here.
Author
There was a problem hiding this comment.
Thank you for the explanation
| -Dtests=false \ | ||
| -Dumockdev_tests=disabled \ | ||
| -Dvalgrind=disabled \ | ||
| -Dvendor_ids_dir=/usr/share/hwdata \ |
Author
There was a problem hiding this comment.
Just as a note: I tried to re-order the options based on https://github.com/fwupd/fwupd/blob/main/meson_options.txt
ma-neumann
commented
Mar 19, 2026
| -Dpolkit=disabled \ | ||
| -Dpython=$(HOST_PYTHON3_BIN) \ | ||
| -Dqubes=false \ | ||
| -Dreadline=disabled \ |
Author
There was a problem hiding this comment.
@lvoegl Would it make sense to add readline as dependency?
Contributor
There was a problem hiding this comment.
If it's not added fwupd provides it's own readline implementation. Adding it as a config option was possible, but disabling it wouldn't be a problem for me.
9d1a2b3 to
73b859f
Compare
Signed-off-by: Martin Neumann <mneumann@teco.edu>
lvoegl
approved these changes
Mar 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @lvoegl
Description:
🧪 Run Testing Details
✅ Formalities