luci-mod-network: add speed choices via rpc device status#8282
Open
sion-111 wants to merge 1 commit intoopenwrt:masterfrom
Open
luci-mod-network: add speed choices via rpc device status#8282sion-111 wants to merge 1 commit intoopenwrt:masterfrom
sion-111 wants to merge 1 commit intoopenwrt:masterfrom
Conversation
Add speed choices populated from rpc device status while still allowing manual custom values to be entered. Signed-off-by: sion-111 <s.piotrowski91@gmail.com>
Failed checksIssues marked with an ❌ are failing checks. Commit 0a4e7b3
For more details, see the full job log. Something broken? Consider providing feedback. |
Contributor
|
Can you fix the formalities, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a speed selection field to device settings in LuCI.
Available speeds are populated dynamically using
network.device statusvia RPC, while still allowing manual custom values to be entered.
ACL permissions were extended to allow read-only access to
network.device status.Tested on Banana Pi BPI-R4.
Signed-off-by: sion-111 <s.piotrowski91@gmail.com><package name>: titlefirst line subjectPKG_VERSIONin the Makefile (not applicable)