Add heating schedule setter for circuits#701
Conversation
lackas
force-pushed
the
feature/heating-schedule-setter
branch
from
93e6ce0 to
c23842b
Compare
|
See also PR #368 which adds |
PyViCare/PyViCareHeatingDevice.py
Outdated
| } | ||
|
|
||
| @handleAPICommandErrors | ||
| def setHeatingSchedule(self, schedule): |
There was a problem hiding this comment.
Sure! The schedule structure is a nested dict (day keys → list of time slot dicts), so the most accurate type would be quite verbose. Would dict be sufficient, or do you have something more specific in mind? Note that the existing setDomesticHotWaterCirculationSchedule has the same untyped schedule parameter — happy to type that one too while we're at it.
There was a problem hiding this comment.
Then lets go with a dict, the we at least have something.
|
@CFenner Friendly ping — any thoughts on the typing approach for the schedule parameter? Happy to go with |
lackas
force-pushed
the
feature/heating-schedule-setter
branch
from
5684a19 to
3adbd0b
Compare
|
Added |
Adds ability to set heating circuit schedules via the API, complementing the existing getHeatingSchedule() method. Fixes openviess#539
lackas
force-pushed
the
feature/heating-schedule-setter
branch
from
3adbd0b to
0e75f2d
Compare
|
Hey @CFenner, I wanted to ping you regarding this PR, but also flag something that might be related: over the past few days it seems like several setter endpoints have disappeared from the Viessmann API. For example, I can no longer trigger a one-time DHW charge via Home Assistant in a PV automation on my Vitocal 300-G — something I had been using regularly. I just ran a fresh Interestingly, the ViCare app still seems to work fine for controlling the devices. Have you ever looked into how the app does its job — whether it uses the same API or something different? Have you noticed the same? I'm wondering if this affects the scope of PRs like this one as well, or whether it's worth documenting this on the PyViCare side. Would love to hear your thoughts — and happy to help investigate further if useful. Grüße aus Köln! 🙂 |
|
⛷️ See home-assistant/core#165440 & ViCare discord channel |
Not sure what you are trying to day here - is it a temporary issue? Or will we need paid accounts? do you have a link to the discord channel? |
It's in the readMe. |
|
@CFenner Friendly ping on this one too — still merges cleanly against master. Happy to adjust anything if you have feedback on the approach. |
3 participants
Summary
Adds methods to set heating circuit schedules:
setHeatingSchedule(schedule)- set the heating schedule for a circuitgetHeatingScheduleModes()- get available schedule modes (e.g., reduced, normal, fixed)This complements the existing
getHeatingSchedule()method and follows the same pattern assetDomesticHotWaterCirculationSchedule().Fixes #539
Test plan
getHeatingScheduleModes()using Vitocal300G test data