[script] support headless user setup for new Raspbian OS#154
[script] support headless user setup for new Raspbian OS#154jwhui merged 1 commit intoopenthread:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a breaking change in newer Raspbian OS versions (Debian Bookworm) that prevents headless SSH access until a user is manually configured. It introduces an automated mechanism to pre-configure a default user during the image creation process, thereby restoring the seamless headless setup experience that existed in previous OS versions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
f9f2ca0 to
f4da47f
Compare
There was a problem hiding this comment.
Code Review
This pull request adds support for headless setup on new Raspbian OS versions by creating a "userconf.txt" file. However, it introduces a critical security vulnerability by pre-configuring a default 'pi' user with a hardcoded, weak password ('raspberry'), which re-introduces a security risk that OS maintainers sought to eliminate. The review focuses on addressing this by requiring the password to be set via an environment variable.
f4da47f to
d0753f3
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
The pull request introduces changes to support headless user setup for new Raspbian OS (Debian Bookworm) by pre-configuring a 'pi' user with a password. However, this re-introduces a significant security risk by hardcoding the default password 'raspberry' directly within the make-reference-release.bash script, which can lead to unauthorized access and exposure in build logs due to set -x. It is crucial to avoid hardcoding default passwords and instead require user-provided credentials or SSH keys during the build process.
|
@jwhui If there are no concerns, could this PR be merged soon? |
In new Raspi OS (Debian Bookworm), the first-boot wizard is mandatory and prevents SSH access until a user is configured.
To maintain the existing headless setup flow (which previously worked on Debian Buster), this change adds a
userconf.txtfile to the boot partition, and pre-configures a defaultpiuser with the passwordraspberry.