Skip to content

[script] support headless user setup for new Raspbian OS#154

Merged
jwhui merged 1 commit intoopenthread:mainfrom
yangsong-cnyn:user_passwd_bookworm
Mar 6, 2026
Merged

[script] support headless user setup for new Raspbian OS#154
jwhui merged 1 commit intoopenthread:mainfrom
yangsong-cnyn:user_passwd_bookworm

Conversation

@yangsong-cnyn
Copy link
Contributor

In new Raspi OS (Debian Bookworm), the first-boot wizard is mandatory and prevents SSH access until a user is configured.

To maintain the existing headless setup flow (which previously worked on Debian Buster), this change adds a userconf.txt file to the boot partition, and pre-configures a default pi user with the password raspberry.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a breaking change in newer Raspbian OS versions (Debian Bookworm) that prevents headless SSH access until a user is manually configured. It introduces an automated mechanism to pre-configure a default user during the image creation process, thereby restoring the seamless headless setup experience that existed in previous OS versions.

Highlights

  • Headless Setup for New Raspbian OS: Implemented a solution to enable headless setup for new Raspbian OS (Debian Bookworm) versions, which now mandate a first-boot wizard and prevent SSH access until a user is configured.
  • Automated User Configuration: Added logic to create a userconf.txt file on the boot partition, pre-configuring a default 'pi' user with the password 'raspberry' to bypass the first-boot wizard.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • script/make-raspbian.bash
    • Added code to generate a SHA-512 password hash for the 'raspberry' password.
    • Included a step to create 'userconf.txt' in the boot partition with the pre-configured 'pi' user and its hash.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@Irving-cl Irving-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for headless setup on new Raspbian OS versions by creating a "userconf.txt" file. However, it introduces a critical security vulnerability by pre-configuring a default 'pi' user with a hardcoded, weak password ('raspberry'), which re-introduces a security risk that OS maintainers sought to eliminate. The review focuses on addressing this by requiring the password to be set via an environment variable.

@yangsong-cnyn yangsong-cnyn changed the title support headless user setup for new Raspbian OS [script] support headless user setup for new Raspbian OS Mar 5, 2026
@yangsong-cnyn yangsong-cnyn added the enhancement New feature or request label Mar 5, 2026
@yangsong-cnyn yangsong-cnyn force-pushed the user_passwd_bookworm branch from f4da47f to d0753f3 Compare March 5, 2026 05:22
@yangsong-cnyn
Copy link
Contributor Author

/gemini review

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces changes to support headless user setup for new Raspbian OS (Debian Bookworm) by pre-configuring a 'pi' user with a password. However, this re-introduces a significant security risk by hardcoding the default password 'raspberry' directly within the make-reference-release.bash script, which can lead to unauthorized access and exposure in build logs due to set -x. It is crucial to avoid hardcoding default passwords and instead require user-provided credentials or SSH keys during the build process.

@Nitin-GRL
Copy link

@jwhui If there are no concerns, could this PR be merged soon?

@jwhui jwhui merged commit a3595f6 into openthread:main Mar 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants