Skip to content

OCPBUGS-72591: Lower verbosity for parseIPList empty list logging#709

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
alebedev87:fix-parse-ip-list-vebose-logging
Jan 23, 2026
Merged

OCPBUGS-72591: Lower verbosity for parseIPList empty list logging#709
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
alebedev87:fix-parse-ip-list-vebose-logging

Conversation

@alebedev87
Copy link
Contributor

Since it's impossible to distinguish between an unset value and a value set as empty, we prefer to lower the verbosity from V(0) to V(7) to reduce unnecessary logging.

Since it's impossible to distinguish between an unset value and a value
set as empty, we prefer to lower the verbosity from V(0) to V(7) to
reduce unnecessary logging.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 12, 2026
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-72591, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Since it's impossible to distinguish between an unset value and a value set as empty, we prefer to lower the verbosity from V(0) to V(7) to reduce unnecessary logging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 12, 2026
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-72591, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@davidesalerno
Copy link
Contributor

/assign

@Miciah
Copy link
Contributor

Miciah commented Jan 21, 2026

/approve

Do we document the various log levels anywhere? It would be useful to have some guidance for both developers and end users, to help everyone understand in general terms what gets logged (or should be logged) at a given log level.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2026
@davidesalerno
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2026
@ShudiLi
Copy link
Member

ShudiLi commented Jan 23, 2026

Tested it with 4.22.0-0-2026-01-23-022622-test-ci-ln-lnmj02t-latest

1.
% oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.22.0-0-2026-01-23-022622-test-ci-ln-lnmj02t-latest   True        False         51m     Cluster version is 4.22.0-0-2026-01-23-022622-test-ci-ln-lnmj02t-latest

2. Create a deployment and the service, then created 821 routes by a script
% oc get route | wc -l
     821

3. check the router log
% oc -n openshift-ingress logs router-default-65cc98b975-4td49
I0123 03:01:28.155400       1 template.go:561] "msg"="starting router" "logger"="router" "version"="majorFromGit: \nminorFromGit: \ncommitFromGit: bfa60faf\nversionFromGit: v0.0.0-unknown\ngitTreeState: dirty\nbuildDate: 2026-01-23T02:18:38Z\n"
I0123 03:01:28.156333       1 envvar.go:172] "Feature gate default state" feature="WatchListClient" enabled=false
I0123 03:01:28.156353       1 envvar.go:172] "Feature gate default state" feature="ClientsAllowCBOR" enabled=false
I0123 03:01:28.156359       1 envvar.go:172] "Feature gate default state" feature="ClientsPreferCBOR" enabled=false
I0123 03:01:28.156363       1 envvar.go:172] "Feature gate default state" feature="InOrderInformers" enabled=true
I0123 03:01:28.156367       1 envvar.go:172] "Feature gate default state" feature="InformerResourceVersion" enabled=false
I0123 03:01:28.160753       1 metrics.go:156] "msg"="router health and metrics port listening on HTTP and HTTPS" "address"="0.0.0.0:1936" "logger"="metrics"
I0123 03:01:28.163352       1 router.go:214] "msg"="creating a new template router" "logger"="template" "writeDir"="/var/lib/haproxy"
I0123 03:01:28.163461       1 router.go:298] "msg"="router will coalesce reloads within an interval of each other" "interval"="5s" "logger"="template"
I0123 03:01:28.163954       1 router.go:368] "msg"="watching for changes" "logger"="template" "path"="/etc/pki/tls/private"
I0123 03:01:28.164022       1 router.go:283] "msg"="router is including routes in all namespaces" "logger"="router"
I0123 03:01:28.187691       1 reflector.go:436] "Caches populated" type="*v1.EndpointSlice" reflector="github.com/openshift/router/pkg/router/controller/factory/factory.go:124"
I0123 03:01:28.188747       1 reflector.go:436] "Caches populated" type="*v1.Route" reflector="github.com/openshift/router/pkg/router/controller/factory/factory.go:124"
I0123 03:01:28.188976       1 reflector.go:436] "Caches populated" type="*v1.Service" reflector="github.com/openshift/router/pkg/router/template/service_lookup.go:33"
E0123 03:01:28.272838       1 haproxy.go:418] "Unhandled Error" err="can't scrape HAProxy: dial unix /var/lib/haproxy/run/haproxy.sock: connect: no such file or directory" logger="UnhandledError"
I0123 03:01:28.359040       1 router.go:665] "msg"="router reloaded" "logger"="template" "output"=" - Checking http://localhost:80 ...\n - Health check ok : 0 retry attempt(s).\n"
...
I0123 04:02:06.023801       1 router.go:665] "msg"="router reloaded" "logger"="template" "output"=" - Checking http://localhost:80 ...\n - Health check ok : 0 retry attempt(s).\n"
%

4.
% oc scale deployment appach-server --replicas=11
deployment.apps/appach-server scaled

5.  Checked the router log again, there isn't the parseIPList log
% oc -n openshift-ingress logs router-default-65cc98b975-4td49 | grep parseIPList
% 

Could see the parseIPList log in 4.22.0-0.nightly-2026-01-22-122134

1.
% oc get clusterversion
NAME      VERSION                              AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.22.0-0.nightly-2026-01-22-122134   True        False         3h8m    Cluster version is 4.22.0-0.nightly-2026-01-22-122134

2.
% oc -n openshift-ingress logs router-default-5766cff688-9ctw5   | grep parseIPList
I0123 03:01:23.596772       1 template_helper.go:370] "msg"="parseIPList empty list found" "logger"="template"
I0123 03:01:23.597203       1 template_helper.go:370] "msg"="parseIPList empty list found" "logger"="template"
I0123 03:01:23.597529       1 template_helper.go:370] "msg"="parseIPList empty list found" "logger"="template"
I0123 03:01:23.597845       1 template_helper.go:370] "msg"="parseIPList empty list found" "logger"="template"
I0123 03:01:23.598182       1 template_helper.go:370] "msg"="parseIPList empty list found" "logger"="template"
I0123 03:01:23.598495       1 template_helper.go:370] "msg"="parseIPList empty list found" "logger"="template"
I0123 03:01:23.598820       1 template_helper.go:370] "msg"="parseIPList empty list found" "logger"="template"
I0123 03:01:23.599166       1 template_helper.go:370] "msg"="parseIPList empty list found" "logger"="template"

@ShudiLi
Copy link
Member

ShudiLi commented Jan 23, 2026

/label qe-approved
/verified by @ShudiLi

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jan 23, 2026
@openshift-ci-robot
Copy link
Contributor

@alebedev87: This pull request references Jira Issue OCPBUGS-72591, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

Details

In response to this:

Since it's impossible to distinguish between an unset value and a value set as empty, we prefer to lower the verbosity from V(0) to V(7) to reduce unnecessary logging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from ShudiLi January 23, 2026 05:38
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 23, 2026
@openshift-ci-robot
Copy link
Contributor

@ShudiLi: This PR has been marked as verified by @ShudiLi.

Details

In response to this:

/label qe-approved
/verified by @ShudiLi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9db967e and 2 for PR HEAD 3c42bc7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit d2db065 into openshift:master Jan 23, 2026
10 checks passed
@openshift-ci-robot
Copy link
Contributor

@alebedev87: Jira Issue Verification Checks: Jira Issue OCPBUGS-72591
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-72591 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Since it's impossible to distinguish between an unset value and a value set as empty, we prefer to lower the verbosity from V(0) to V(7) to reduce unnecessary logging.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-01-24-213011

@alebedev87
Copy link
Contributor Author

/cherry-pick release-4.21

@openshift-cherrypick-robot

@alebedev87: new pull request created: #752

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants