Skip to content

rhdh: remove required_pull_request_reviews from rhdh repos#75669

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
kadel:cleanup-rhdh
Mar 4, 2026
Merged

rhdh: remove required_pull_request_reviews from rhdh repos#75669
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
kadel:cleanup-rhdh

Conversation

@kadel
Copy link
Member

@kadel kadel commented Mar 4, 2026

This was creating issues.
Tide was not merging PRs that were lgtmed by people without write access, even if they were in OWNERS fle.

@openshift-ci openshift-ci bot requested review from OpinionatedHeron and rm3l March 4, 2026 13:41
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 4, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@kadel: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

@kadel: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel, rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4297176 into openshift:main Mar 4, 2026
10 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

@kadel: Updated the config configmap in namespace ci at cluster app.ci using the following files:

  • key core-services-prow-02_config-redhat-developer-rhdh-chart-_prowconfig.yaml using file core-services/prow/02_config/redhat-developer/rhdh-chart/_prowconfig.yaml
  • key core-services-prow-02_config-redhat-developer-rhdh-operator-_prowconfig.yaml using file core-services/prow/02_config/redhat-developer/rhdh-operator/_prowconfig.yaml
  • key core-services-prow-02_config-redhat-developer-rhdh-_prowconfig.yaml using file core-services/prow/02_config/redhat-developer/rhdh/_prowconfig.yaml
Details

In response to this:

This was creating issues.
Tide was not merging PRs that were lgtmed by people without write access, even if they were in OWNERS fle.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants