[WIP] Add cluster runtime constraints handling

[perdasilva]

Signed-off-by: Per G. da Silva perdasilva@redhat.com

Description

This the downstream component of the work being done in operator-framework/operator-lifecycle-manager#2498 to enable side loading of runtime constraints. Here, we add the runtime constratins file the operator image and update the olm catalog operator deployment manifest to include the environment variable (RUNTIME_CONSTRAINTS), which points to the runtime constraints file in the local filesystem, and enables the feature

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: perdasilva
To complete the pull request process, please assign timflannagan after the PR has been reviewed.
You can assign the PR to them by writing /assign @timflannagan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @perdasilva. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[njhale]

Does this belong in docs.go? i.e. looks like something we want in the go docs.

[perdasilva]

Could you please be more specific for me: do you mean there's a docs place in this repo? do you mean upstream? do you mean docstrings in the code?

My intent here is to add developer documentation - just so people get the context of why that file exists there. Once we have the right way of doing things, then all of this should go away.

It is still my intention to add user facing docs though - but I was thinking of doing that in the upstream

[njhale]

Sorry -- Go doc strings; e.g. https://github.com/kubernetes-sigs/controller-runtime/blob/master/doc.go autogenerates developer docs at https://pkg.go.dev/sigs.k8s.io/controller-runtime

[njhale]

It seems more apt to call it something like "global" or "static" than "cluster runtime", since this could be conflated with the "virtual bundle" concept mapped out in some of the EPs.

[perdasilva]

damn - I see a lot of refactoring in my future now hahaha

[njhale]

Please see operator-framework/operator-lifecycle-manager#2498 (review) for my thoughts on this.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-ci]

@perdasilva: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-olm	51daad6	link	true	/test e2e-gcp-olm
ci/prow/unit-psm	51daad6	link	true	/test unit-psm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.