Skip to content

NO-JIRA: fix flaky TestReconcile/machine_with_node_likely_to_go_unhealthy#1483 #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Mar 19, 2026
Merged

NO-JIRA: fix flaky TestReconcile/machine_with_node_likely_to_go_unhealthy#1483 #1483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/controller/machinehealthcheck/machinehealthcheck_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ type testCase struct {
expectedStatus *machinev1.MachineHealthCheckStatus
externalRemediationMachine *unstructured.Unstructured
externalRemediationTemplate *unstructured.Unstructured
// setup is called immediately before the reconcile to allow time-sensitive
// test cases to refresh state (e.g. LastTransitionTime) right before execution.
setup func()
}

type expectedReconcile struct {
Expand Down Expand Up @@ -325,6 +328,9 @@ func TestReconcile(t *testing.T) {
machine: machineWithNodeRecentlyUnhealthy,
node: nodeRecentlyUnhealthy,
mhc: machineHealthCheck,
setup: func() {
nodeRecentlyUnhealthy.Status.Conditions[0].LastTransitionTime = metav1.Time{Time: time.Now()}
},
expected: expectedReconcile{
result: reconcile.Result{
RequeueAfter: 300 * time.Second,
Expand Down Expand Up @@ -488,6 +494,9 @@ func TestReconcile(t *testing.T) {

for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
if tc.setup != nil {
tc.setup()
}
recorder := record.NewFakeRecorder(2)
r := newFakeReconcilerWithCustomRecorder(recorder, buildRunTimeObjects(tc)...)
assertBaseReconcile(t, tc, ctx, r)
Expand Down