Skip to content

[release-4.19] OCPBUGS-56227: correct aws kms permissions#1371

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-1370-to-release-4.19
May 16, 2025
Merged

[release-4.19] OCPBUGS-56227: correct aws kms permissions#1371
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.19from
openshift-cherrypick-robot:cherry-pick-1370-to-release-4.19

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #1370

/assign Phaow

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-56159 has been cloned as Jira Issue OCPBUGS-56227. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-56227: correct aws kms permissions

Details

In response to this:

This is an automated cherry-pick of #1370

/assign Phaow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-56159: correct aws kms permissions [release-4.19] OCPBUGS-56227: correct aws kms permissions May 15, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 15, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56227, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #1370

/assign Phaow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Phaow
Copy link
Contributor

Phaow commented May 15, 2025

Hi @JoelSpeed , I think we could backport to 4.19 only since 4.19.0 not release yet, in z-stream better to not change permissions, right? Feel free to corret me if there's some potential risk, thank you!
/assign @JoelSpeed

@Phaow
Copy link
Contributor

Phaow commented May 15, 2025

cc @yunjiang29 @gpei

@JoelSpeed
Copy link
Contributor

/approve
/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 15, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2025
@Phaow
Copy link
Contributor

Phaow commented May 15, 2025

/label cherry-pick-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 15, 2025

@Phaow: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Phaow
Copy link
Contributor

Phaow commented May 15, 2025

@sunzhaohua2 @huali9 Could you please help add the cherry-pick-approved label since we already verify it works? Thank you!

@Phaow
Copy link
Contributor

Phaow commented May 15, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 15, 2025
@openshift-ci-robot
Copy link
Contributor

@Phaow: This pull request references Jira Issue OCPBUGS-56227, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-56159 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-56159 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gpei May 15, 2025 12:46
@huali9
Copy link
Contributor

huali9 commented May 16, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 16, 2025
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 02df956 and 2 for PR HEAD a76d65e in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 16, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn a76d65e link false /test e2e-azure-ovn
ci/prow/e2e-gcp-operator a76d65e link false /test e2e-gcp-operator
ci/prow/e2e-openstack a76d65e link false /test e2e-openstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Phaow
Copy link
Contributor

Phaow commented May 16, 2025

security check failed caused by

[Low] Improper Certificate Validation
   ID: 2d552384-7893-4a9b-9d9f-c799aadf5f3d 
   Path: pkg/webhooks/v1beta1_suite_test.go, line 48 
   Info: TrustManager might be too permissive: The client will accept any certificate and any host name in that certificate, making it susceptible to man-in-the-middle attacks.

not caused by the fix commit, @JoelSpeed could you help override it? Thank you!

@JoelSpeed
Copy link
Contributor

/test security

@openshift-merge-bot openshift-merge-bot bot merged commit 5eb6a36 into openshift:release-4.19 May 16, 2025
27 of 30 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-56227: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-56227 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #1370

/assign Phaow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-api-operator
This PR has been included in build ose-machine-api-operator-container-v4.19.0-202505161145.p0.g5eb6a36.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-05-17-005111

@patrickdillon
Copy link
Contributor

/cherry-pick release-4.18

@openshift-cherrypick-robot
Copy link
Author

@patrickdillon: new pull request created: #1478

Details

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants