[release-4.19] OCPBUGS-56227: correct aws kms permissions#1371
Conversation
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-56159 has been cloned as Jira Issue OCPBUGS-56227. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56227, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @JoelSpeed , I think we could backport to 4.19 only since 4.19.0 not release yet, in z-stream better to not change permissions, right? Feel free to corret me if there's some potential risk, thank you! |
|
cc @yunjiang29 @gpei |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/label cherry-pick-approved |
|
@Phaow: Can not set label cherry-pick-approved: Must be member in one of these teams: [] DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@sunzhaohua2 @huali9 Could you please help add the |
|
/jira refresh |
|
@Phaow: This pull request references Jira Issue OCPBUGS-56227, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label cherry-pick-approved |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[Low] Improper Certificate Validation
ID: 2d552384-7893-4a9b-9d9f-c799aadf5f3d
Path: pkg/webhooks/v1beta1_suite_test.go, line 48
Info: TrustManager might be too permissive: The client will accept any certificate and any host name in that certificate, making it susceptible to man-in-the-middle attacks.not caused by the fix commit, @JoelSpeed could you help override it? Thank you! |
|
/test security |
5eb6a36
into
openshift:release-4.19
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-56227: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-56227 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-api-operator |
|
Fix included in accepted release 4.19.0-0.nightly-2025-05-17-005111 |
|
/cherry-pick release-4.18 |
|
@patrickdillon: new pull request created: #1478 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #1370
/assign Phaow