OCPBUGS-78696: [release-4.21] : Disable LoadBalancer in cloud config when Octavia is unavailable#10399
Conversation
…ilable When Octavia (load-balancer) endpoint is not available in the OpenStack service catalog, explicitly set [LoadBalancer] enabled = false in the cloud provider config. This prevents the Cloud Controller Manager from crashing on startup due to an upstream change in cloud-provider-openstack that changed error handling from klog.Errorf to klog.Fatalf when the LoadBalancer client cannot be created. The fix uses the same pattern already established in the cluster destroy code (pkg/destroy/openstack/openstack.go) to detect Octavia availability by checking for gophercloud.ErrEndpointNotFound. Fixes: https://issues.redhat.com/browse/OCPBUGS-64842 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: eshulman2. Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@openshift-cherrypick-robot: An error was encountered cloning bug for cherrypick for bug OCPBUGS-64842 on the Jira server at https://redhat.atlassian.net. No known errors were detected, please see the full error message for details. Full error message.
request failed. Please analyze the request body for more details. Status code: 400: {"errorMessages":[],"errors":{"customfield_10001":"Team id 'JsonData{data={avatarUrl=, id=ec74d716-af36-4b3c-950f-f79213d08f71-2185, isShared=true, isVerified=false, isVisible=true, name=rhos-conplat-osasinfra, title=rhos-conplat-osasinfra}}' is not valid.","rankBeforeIssue":"expected Object","rankAfterIssue":"expected Object"}}
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
mandre
left a comment
There was a problem hiding this comment.
/lgtm
/approve
/label backport-risk-assessed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/rename OCPBUGS-64842 [release-4.21] : Disable LoadBalancer in cloud config when Octavia is unavailable |
|
/retitle OCPBUGS-64842 [release-4.21] : Disable LoadBalancer in cloud config when Octavia is unavailable |
|
/retitle OCPBUGS-78696: [release-4.21] : Disable LoadBalancer in cloud config when Octavia is unavailable |
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-78696, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@eshulman2: This pull request references Jira Issue OCPBUGS-78696, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/verified later @eshulman2 |
|
@mandre: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
This is an automated cherry-pick of #10326
/assign eshulman2