CONSOLE-4447: Additional modals switched to use ModalFooterWithAlerts for consistency

[sg00dwin]

Migrates 4 modals to use ModalFooterWithAlerts for error display,
matching the pattern established in #16015:

• delete-namespace-modal: Replace inline ErrorMessage with ModalFooterWithAlerts
• add-group-users-modal: Move error Alert from body to ModalFooterWithAlerts in footer
• TextInputModal: Move error Alert from form body to ModalFooterWithAlerts in footer
• CreateServiceAccountModal: Move error Alert from form body to ModalFooterWithAlerts in footer

Also normalizes Cancel button variants to "link" where they were "secondary".

Summary by CodeRabbit

• Bug Fixes

  • Improved error message display in modals by centralizing error presentation in the footer area for better visibility and consistency across the application.

• Style

  • Updated cancel button styling in one modal for improved visual hierarchy.

[openshift-ci-robot]

@sg00dwin: This pull request references CONSOLE-4447 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Migrates 4 modals to use ModalFooterWithAlerts for error display,
matching the pattern established in #16015:

• delete-namespace-modal: Replace inline ErrorMessage with ModalFooterWithAlerts
• add-group-users-modal: Move error Alert from body to ModalFooterWithAlerts in footer
• TextInputModal: Move error Alert from form body to ModalFooterWithAlerts in footer
• CreateServiceAccountModal: Move error Alert from form body to ModalFooterWithAlerts in footer

Also normalizes Cancel button variants to "link" where they were "secondary".

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sg00dwin]

/verified by @sg00dwin

[openshift-ci-robot]

@sg00dwin: This PR has been marked as verified by @sg00dwin.

Details

In response to this:

/verified by @sg00dwin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sg00dwin]

Tech debt
/label docs-approved
/label px-approved

[openshift-ci-robot]

@sg00dwin: This pull request references CONSOLE-4447 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Migrates 4 modals to use ModalFooterWithAlerts for error display,
matching the pattern established in #16015:

• delete-namespace-modal: Replace inline ErrorMessage with ModalFooterWithAlerts
• add-group-users-modal: Move error Alert from body to ModalFooterWithAlerts in footer
• TextInputModal: Move error Alert from form body to ModalFooterWithAlerts in footer
• CreateServiceAccountModal: Move error Alert from form body to ModalFooterWithAlerts in footer

Also normalizes Cancel button variants to "link" where they were "secondary".

Summary by CodeRabbit

• Bug Fixes

• Improved error message display in modals by centralizing error presentation in the footer area for better visibility and consistency across the application.

• Style

• Updated cancel button styling in one modal for improved visual hierarchy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 782e0933-44f3-4450-b5bf-585bc86d4ed3

📥 Commits

Reviewing files that changed from the base of the PR and between b13a1ad and 0049115.

📒 Files selected for processing (5)

• frontend/packages/console-app/src/components/modals/add-group-users-modal.tsx
• frontend/packages/console-shared/src/components/modals/TextInputModal.tsx
• frontend/packages/operator-lifecycle-manager-v1/locales/en/olm-v1.json
• frontend/packages/operator-lifecycle-manager-v1/src/components/cluster-extension/CreateServiceAccountModal.tsx
• frontend/public/components/modals/delete-namespace-modal.tsx

💤 Files with no reviewable changes (1)

• frontend/packages/operator-lifecycle-manager-v1/locales/en/olm-v1.json

📜 Recent review details

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• frontend/public/components/modals/delete-namespace-modal.tsx
• frontend/packages/operator-lifecycle-manager-v1/src/components/cluster-extension/CreateServiceAccountModal.tsx
• frontend/packages/console-app/src/components/modals/add-group-users-modal.tsx
• frontend/packages/console-shared/src/components/modals/TextInputModal.tsx

🧬 Code graph analysis (4)

frontend/public/components/modals/delete-namespace-modal.tsx (1)

frontend/packages/console-shared/src/components/modals/ModalFooterWithAlerts.tsx (1)

• ModalFooterWithAlerts (5-25)

frontend/packages/operator-lifecycle-manager-v1/src/components/cluster-extension/CreateServiceAccountModal.tsx (1)

frontend/packages/console-shared/src/components/modals/ModalFooterWithAlerts.tsx (1)

• ModalFooterWithAlerts (5-25)

frontend/packages/console-app/src/components/modals/add-group-users-modal.tsx (1)

frontend/packages/console-shared/src/components/modals/ModalFooterWithAlerts.tsx (1)

• ModalFooterWithAlerts (5-25)

frontend/packages/console-shared/src/components/modals/TextInputModal.tsx (1)

frontend/packages/console-shared/src/components/modals/ModalFooterWithAlerts.tsx (1)

• ModalFooterWithAlerts (5-25)

🔇 Additional comments (4)

frontend/public/components/modals/delete-namespace-modal.tsx (1)

27-27: Footer alert migration looks correct and behavior-preserving.

Using ModalFooterWithAlerts with errorMessage keeps the submit/cancel flow intact while standardizing error presentation in this modal.

Also applies to: 110-124

frontend/packages/console-app/src/components/modals/add-group-users-modal.tsx (1)

3-10: Good consolidation of modal error handling into the footer.

The updated footer wiring cleanly centralizes errorMessage display without changing submission/loading behavior.

Also applies to: 76-89

frontend/packages/console-shared/src/components/modals/TextInputModal.tsx (1)

17-17: This refactor is clean and consistent with the shared modal-footer alert pattern.

Error display is centralized via ModalFooterWithAlerts, and the action wiring remains intact.

Also applies to: 101-123

frontend/packages/operator-lifecycle-manager-v1/src/components/cluster-extension/CreateServiceAccountModal.tsx (1)

16-16: Nice improvement to footer consistency and action-state UX.

ModalFooterWithAlerts integration plus isLoading/isDisabled on actions keeps the flow clear while aligning this modal with the shared pattern.

Also applies to: 112-135

---

📝 Walkthrough

Walkthrough

This pull request refactors error handling UI across multiple modal components. It introduces a centralized ModalFooterWithAlerts component to replace inline error Alert elements and traditional ModalFooter usage. Five files are updated: four modal components in add-group-users-modal, TextInputModal, CreateServiceAccountModal, and delete-namespace-modal have their error presentation moved to the footer area, while one locale file removes an unused translation entry. The changes consolidate error display patterns while maintaining existing form validation and submission logic.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.

OpenGrep is compatible with Semgrep configurations. Add an opengrep.yml or semgrep.yml configuration file to your project to enable OpenGrep analysis.

[rhamilto]

Awesome. Thanks, @sg00dwin!

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[sg00dwin]

/retest-required

[sg00dwin]

/retest

[openshift-ci]

@sg00dwin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-console	59273a0	link	true	/test e2e-gcp-console

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.