OCPBUGS-78731:Move enable-multicast from config maps to CLI flags by tsorya · Pull Request #2939 · openshift/cluster-network-operator

tsorya · 2026-03-18T16:09:08Z

Remove enable-multicast=true from ovnkube config maps and pass it directly as --enable-multicast on the ovnkube CLI for node and control plane processes (both self-hosted and managed).

Made-with: Cursor

coderabbitai · 2026-03-18T16:09:59Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7a2213de-b13a-4b3a-a0b1-26ec1b6f2429

📥 Commits

Reviewing files that changed from the base of the PR and between 3b5ef2d and f046691.

📒 Files selected for processing (6)

bindata/network/ovn-kubernetes/common/008-script-lib.yaml
bindata/network/ovn-kubernetes/managed/004-config.yaml
bindata/network/ovn-kubernetes/managed/ovnkube-control-plane.yaml
bindata/network/ovn-kubernetes/self-hosted/004-config.yaml
bindata/network/ovn-kubernetes/self-hosted/ovnkube-control-plane.yaml
pkg/network/ovn_kubernetes_test.go

💤 Files with no reviewable changes (3)

pkg/network/ovn_kubernetes_test.go
bindata/network/ovn-kubernetes/self-hosted/004-config.yaml
bindata/network/ovn-kubernetes/managed/004-config.yaml

Walkthrough

The changes refactor multicast configuration in OVN Kubernetes deployments, removing static enable-multicast settings from ConfigMaps while adding --enable-multicast flags to startup commands across multiple deployment configurations and updating test expectations accordingly.

Changes

Cohort / File(s)	Summary
Multicast Configuration Removal `bindata/network/ovn-kubernetes/managed/004-config.yaml`, `bindata/network/ovn-kubernetes/self-hosted/004-config.yaml`	Removed enable-multicast=true entries from ConfigMap configurations; multicast support is now controlled via command-line flags instead.
Multicast Flag Addition `bindata/network/ovn-kubernetes/common/008-script-lib.yaml`, `bindata/network/ovn-kubernetes/managed/ovnkube-control-plane.yaml`, `bindata/network/ovn-kubernetes/self-hosted/ovnkube-control-plane.yaml`	Added --enable-multicast flag to ovnkube startup commands across common and managed/self-hosted control plane configurations.
Test Expectations Update `pkg/network/ovn_kubernetes_test.go`	Removed multicast toggle assertions from test-generated configuration blocks to reflect the shift from ConfigMap-based to flag-based multicast configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci · 2026-03-18T16:10:13Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2026-03-18T16:19:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tsorya
Once this PR has been reviewed and has the lgtm label, please assign jcaamano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Remove enable-multicast=true from ovnkube config maps and pass it directly as --enable-multicast on the ovnkube CLI for node and control plane processes (both self-hosted and managed). Made-with: Cursor

openshift-ci-robot · 2026-03-18T17:53:39Z

@tsorya: This pull request references Jira Issue OCPBUGS-78731, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Remove enable-multicast=true from ovnkube config maps and pass it directly as --enable-multicast on the ovnkube CLI for node and control plane processes (both self-hosted and managed).

Made-with: Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

arkadeepsen · 2026-03-18T18:02:59Z

/hold

The revert PR #2938 should go in first

tsorya · 2026-03-18T19:12:33Z

oc exec -it -n openshift-ovn-kubernetes ovnkube-node-bpkjk -- bash [root@dhcp-8-231-235 ~]# ovn-nbctl find ACL | grep -i mcast match : "(ip4.mcast || mldv1 || mldv2 || (ip6.dst[120..127] == 0xff && ip6.dst[116] == 1))" match : "(ip4.mcast || mldv1 || mldv2 || (ip6.dst[120..127] == 0xff && ip6.dst[116] == 1))" match : "outport == @a15696136357465712812 && (igmp || (ip4.src == $a14513626322132345176 && ip4.mcast))" match : "outport == @a4743249366342378346 && (ip4.mcast || mldv1 || mldv2 || (ip6.dst[120..127] == 0xff && ip6.dst[116] == 1))" match : "inport == @a4743249366342378346 && (ip4.mcast || mldv1 || mldv2 || (ip6.dst[120..127] == 0xff && ip6.dst[116] == 1))" match : "inport == @a15696136357465712812 && ip4.mcast"

tsorya · 2026-03-18T19:13:06Z

10.130.0.3 : unicast, xmt/rcv/%loss = 10/10/0%, min/avg/max/std-dev = 0.290/0.404/1.026/0.222 10.130.0.3 : multicast, xmt/rcv/%loss = 10/9/9% (seq>=2 0%), min/avg/max/std-dev = 0.307/0.522/1.115/0.319 10.128.0.30 : unicast, xmt/rcv/%loss = 10/10/0%, min/avg/max/std-dev = 0.314/0.449/0.717/0.140 10.128.0.30 : multicast, xmt/rcv/%loss = 10/9/9% (seq>=2 0%), min/avg/max/std-dev = 0.285/0.445/0.823/0.155

10.128.0.30 : unicast, xmt/rcv/%loss = 10/10/0%, min/avg/max/std-dev = 0.307/0.488/0.991/0.218 10.128.0.30 : multicast, xmt/rcv/%loss = 10/9/9% (seq>=2 0%), min/avg/max/std-dev = 0.313/0.499/1.212/0.273 10.129.0.7 : unicast, xmt/rcv/%loss = 10/10/0%, min/avg/max/std-dev = 0.307/0.462/1.057/0.252 10.129.0.7 : multicast, xmt/rcv/%loss = 10/9/9% (seq>=2 0%), min/avg/max/std-dev = 0.320/0.501/1.513/0.382

tsorya · 2026-03-19T15:33:38Z

/retest-required

openshift-ci · 2026-03-19T19:32:11Z

@tsorya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	`f046691`	link	false	`/test security`
ci/prow/e2e-aws-ovn-rhcos10-techpreview	`f046691`	link	false	`/test e2e-aws-ovn-rhcos10-techpreview`
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp	`f046691`	link	true	`/test e2e-metal-ipi-ovn-dualstack-bgp`
ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw	`f046691`	link	true	`/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw`
ci/prow/e2e-aws-ovn-hypershift-conformance	`f046691`	link	true	`/test e2e-aws-ovn-hypershift-conformance`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2026

tsorya marked this pull request as ready for review March 18, 2026 17:52

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2026

OCPBUGS-78731: Move enable-multicast from config maps to CLI flags

f046691

Remove enable-multicast=true from ovnkube config maps and pass it directly as --enable-multicast on the ovnkube CLI for node and control plane processes (both self-hosted and managed). Made-with: Cursor

tsorya force-pushed the igal/dpu-host-cleanup branch from d10a34d to f046691 Compare March 18, 2026 17:53

tsorya changed the title ~~Move enable-multicast from config maps to CLI flags~~ OCPBUGS-78731:Move enable-multicast from config maps to CLI flags Mar 18, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 18, 2026

openshift-ci bot requested review from arkadeepsen and danwinship March 18, 2026 17:55

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-78731:Move enable-multicast from config maps to CLI flags#2939

OCPBUGS-78731:Move enable-multicast from config maps to CLI flags#2939
tsorya wants to merge 1 commit intoopenshift:masterfrom
tsorya:igal/dpu-host-cleanup

tsorya commented Mar 18, 2026

Uh oh!

coderabbitai bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

openshift-ci bot commented Mar 18, 2026

Uh oh!

openshift-ci bot commented Mar 18, 2026

Uh oh!

openshift-ci-robot commented Mar 18, 2026

Uh oh!

arkadeepsen commented Mar 18, 2026

Uh oh!

tsorya commented Mar 18, 2026

Uh oh!

tsorya commented Mar 18, 2026

Uh oh!

tsorya commented Mar 19, 2026

Uh oh!

openshift-ci bot commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

tsorya commented Mar 18, 2026

Uh oh!

coderabbitai bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

openshift-ci bot commented Mar 18, 2026

Uh oh!

openshift-ci bot commented Mar 18, 2026

Uh oh!

openshift-ci-robot commented Mar 18, 2026

Uh oh!

arkadeepsen commented Mar 18, 2026

Uh oh!

tsorya commented Mar 18, 2026

Uh oh!

tsorya commented Mar 18, 2026

Uh oh!

tsorya commented Mar 19, 2026

Uh oh!

openshift-ci bot commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai bot commented Mar 18, 2026 •

edited

Loading