NE-2471: Remove feature-set annotations from Sail Library RBAC

[gcs278]

Remove TechPreviewNoUpgrade annotation from Sail ClusterRole and ClusterRoleBinding to avoid breakage when GatewayAPIWithoutOLM is promoted to GA.

Required to merge before openshift/api#2772

[openshift-ci-robot]

@gcs278: This pull request references NE-2471 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Remove TechPreviewNoUpgrade annotation from Sail ClusterRole and ClusterRoleBinding to avoid breakage when GatewayAPIWithoutOLM is promoted to GA.

Required to merge before openshift/api#2772

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 6d81115b-a9d5-4013-bde7-b60165cf54cd

📥 Commits

Reviewing files that changed from the base of the PR and between 128729e and 790388c.

📒 Files selected for processing (2)

• manifests/00-cluster-role-sail-library.yaml
• manifests/01-cluster-role-binding-sail-library.yaml

💤 Files with no reviewable changes (2)

• manifests/01-cluster-role-binding-sail-library.yaml
• manifests/00-cluster-role-sail-library.yaml

---

📝 Walkthrough

Walkthrough

This change removes the release.openshift.io/feature-set annotation containing DevPreviewNoUpgrade,TechPreviewNoUpgrade from two manifest files. The manifests/00-cluster-role-sail-library.yaml file had this annotation removed from the ClusterRole metadata, and manifests/01-cluster-role-binding-sail-library.yaml had the same annotation removed from the ClusterRoleBinding metadata. No modifications were made to RBAC rules, API versions, kinds, or the binding structure. A total of one line was removed from each file.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@gcs278: This PR was included in a payload test run from openshift/origin#30897
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-4.22-upgrade-from-stable-4.21-e2e-gcp-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/0ab81910-23c6-11f1-8635-bf728c1f5aad-0