NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 86cd2ee#858
Conversation
|
@red-hat-konflux[bot]: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Around line 140-141: The two replaces for
github.com/openshift/assisted-service are pinned to different commits
(github.com/openshift/assisted-service/api => ...7de1aab139a0 and
github.com/openshift/assisted-service/models => ...ec3e2e45bc04); update the
go.mod so both module replaces point to the same upstream commit hash (choose
one canonical commit and set both github.com/openshift/assisted-service/api and
github.com/openshift/assisted-service/models to that same
v0.0.0-<timestamp>-<commit> value) to eliminate schema/type drift between api
and models.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 455a28e4-22d1-469c-a5fe-041f30133514
⛔ Files ignored due to path filters (2)
go.sumis excluded by!**/*.sumvendor/modules.txtis excluded by!vendor/**,!**/vendor/**
📒 Files selected for processing (1)
go.mod
go.mod
Outdated
| github.com/openshift/assisted-service/api => github.com/openshift/assisted-service/api v0.0.0-20260322122346-7de1aab139a0 | ||
| github.com/openshift/assisted-service/models => github.com/openshift/assisted-service/models v0.0.0-20260322122346-7de1aab139a0 | ||
| github.com/openshift/assisted-service/models => github.com/openshift/assisted-service/models v0.0.0-20260323142108-ec3e2e45bc04 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Verify current replace SHAs in this repo
api_line=$(rg -n 'github\.com/openshift/assisted-service/api\s*=>\s*github\.com/openshift/assisted-service/api\s+v0\.0\.0-[0-9]+-[0-9a-f]+' go.mod)
models_line=$(rg -n 'github\.com/openshift/assisted-service/models\s*=>\s*github\.com/openshift/assisted-service/models\s+v0\.0\.0-[0-9]+-[0-9a-f]+' go.mod)
echo "api replace: $api_line"
echo "models replace: $models_line"
api_sha=$(echo "$api_line" | sed -E 's/.*-([0-9a-f]{12,})$/\1/')
models_sha=$(echo "$models_line" | sed -E 's/.*-([0-9a-f]{12,})$/\1/')
echo "api SHA: $api_sha"
echo "models SHA: $models_sha"
if [[ "$api_sha" != "$models_sha" ]]; then
echo "WARNING: api/models are pinned to different assisted-service commits."
fi
# Optional upstream check: see whether api module at pinned SHA references a specific models pseudo-version.
# (Read-only network fetch; safe to skip if network is unavailable.)
curl -fsSL "https://raw.githubusercontent.com/openshift/assisted-service/${api_sha}/api/go.mod" \
| rg -n 'github\.com/openshift/assisted-service/models|^module ' || trueRepository: openshift/cluster-api-provider-agent
Length of output: 661
Pin assisted-service/api and assisted-service/models to the same upstream commit.
Line 140 pins api to 7de1aab139a0 while Line 141 pins models to ec3e2e45bc04. Both modules are from the same upstream repository (github.com/openshift/assisted-service) and reference each other—mismatched commits create type/schema drift risk that can cause runtime errors.
Verification: Confirmed version skew
api replace: 140: github.com/openshift/assisted-service/api => ... v0.0.0-20260322122346-7de1aab139a0
models replace: 141: github.com/openshift/assisted-service/models => ... v0.0.0-20260323142108-ec3e2e45bc04
WARNING: api/models are pinned to different assisted-service commits.
Upstream api module declares models v0.0.0 as a dependency with local replace => ../models, confirming tight coupling. Align both to the same verified-compatible upstream snapshot.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` around lines 140 - 141, The two replaces for
github.com/openshift/assisted-service are pinned to different commits
(github.com/openshift/assisted-service/api => ...7de1aab139a0 and
github.com/openshift/assisted-service/models => ...ec3e2e45bc04); update the
go.mod so both module replaces point to the same upstream commit hash (choose
one canonical commit and set both github.com/openshift/assisted-service/api and
github.com/openshift/assisted-service/models to that same
v0.0.0-<timestamp>-<commit> value) to eliminate schema/type drift between api
and models.
4d07dcd to
37daddc
Compare
37daddc to
3a55e24
Compare
3a55e24 to
7516095
Compare
7516095 to
01461e3
Compare
01461e3 to
d4de731
Compare
d4de731 to
c626078
Compare
c626078 to
423de4b
Compare
423de4b to
a4b6645
Compare
a4b6645 to
d98af2c
Compare
…to 86cd2ee Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
d98af2c to
9f85cab
Compare
This PR contains the following updates:
7de1aab->86cd2eeConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.