Skip to content

NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 86cd2ee#858

Open
red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest
Open

NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 86cd2ee#858
red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest

Conversation

@red-hat-konflux
Copy link
Copy Markdown

@red-hat-konflux red-hat-konflux bot commented Mar 23, 2026

This PR contains the following updates:

Package Type Update Change
github.com/openshift/assisted-service/models replace digest 7de1aab -> 86cd2ee

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 23, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@red-hat-konflux[bot]: This pull request explicitly references no jira issue.

Details

In response to this:

This PR contains the following updates:

Package Type Update Change
github.com/openshift/assisted-service/models replace digest 7de1aab -> ec3e2e4

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 23, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

The go.mod file's replace directive for github.com/openshift/assisted-service/models was updated from v0.0.0-20260322122346-7de1aab139a0 to v0.0.0-20260325111547-6989bc25d2c8. (1 line changed)

Changes

Cohort / File(s) Summary
Dependency Version Update
go.mod
Updated the replace directive for github.com/openshift/assisted-service/models to v0.0.0-20260325111547-6989bc25d2c8 (1 line changed).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 23, 2026
@openshift-ci openshift-ci bot requested review from danmanor and eliorerz March 23, 2026 20:18
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 23, 2026

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign eranco74 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@go.mod`:
- Around line 140-141: The two replaces for
github.com/openshift/assisted-service are pinned to different commits
(github.com/openshift/assisted-service/api => ...7de1aab139a0 and
github.com/openshift/assisted-service/models => ...ec3e2e45bc04); update the
go.mod so both module replaces point to the same upstream commit hash (choose
one canonical commit and set both github.com/openshift/assisted-service/api and
github.com/openshift/assisted-service/models to that same
v0.0.0-<timestamp>-<commit> value) to eliminate schema/type drift between api
and models.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 455a28e4-22d1-469c-a5fe-041f30133514

📥 Commits

Reviewing files that changed from the base of the PR and between 63f67e0 and 4d07dcd.

⛔ Files ignored due to path filters (2)
  • go.sum is excluded by !**/*.sum
  • vendor/modules.txt is excluded by !vendor/**, !**/vendor/**
📒 Files selected for processing (1)
  • go.mod

go.mod Outdated
Comment on lines +140 to +141
github.com/openshift/assisted-service/api => github.com/openshift/assisted-service/api v0.0.0-20260322122346-7de1aab139a0
github.com/openshift/assisted-service/models => github.com/openshift/assisted-service/models v0.0.0-20260322122346-7de1aab139a0
github.com/openshift/assisted-service/models => github.com/openshift/assisted-service/models v0.0.0-20260323142108-ec3e2e45bc04
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Verify current replace SHAs in this repo
api_line=$(rg -n 'github\.com/openshift/assisted-service/api\s*=>\s*github\.com/openshift/assisted-service/api\s+v0\.0\.0-[0-9]+-[0-9a-f]+' go.mod)
models_line=$(rg -n 'github\.com/openshift/assisted-service/models\s*=>\s*github\.com/openshift/assisted-service/models\s+v0\.0\.0-[0-9]+-[0-9a-f]+' go.mod)

echo "api replace:    $api_line"
echo "models replace: $models_line"

api_sha=$(echo "$api_line" | sed -E 's/.*-([0-9a-f]{12,})$/\1/')
models_sha=$(echo "$models_line" | sed -E 's/.*-([0-9a-f]{12,})$/\1/')

echo "api SHA:    $api_sha"
echo "models SHA: $models_sha"

if [[ "$api_sha" != "$models_sha" ]]; then
  echo "WARNING: api/models are pinned to different assisted-service commits."
fi

# Optional upstream check: see whether api module at pinned SHA references a specific models pseudo-version.
# (Read-only network fetch; safe to skip if network is unavailable.)
curl -fsSL "https://raw.githubusercontent.com/openshift/assisted-service/${api_sha}/api/go.mod" \
  | rg -n 'github\.com/openshift/assisted-service/models|^module ' || true

Repository: openshift/cluster-api-provider-agent

Length of output: 661


Pin assisted-service/api and assisted-service/models to the same upstream commit.

Line 140 pins api to 7de1aab139a0 while Line 141 pins models to ec3e2e45bc04. Both modules are from the same upstream repository (github.com/openshift/assisted-service) and reference each other—mismatched commits create type/schema drift risk that can cause runtime errors.

Verification: Confirmed version skew
api replace:    140:	github.com/openshift/assisted-service/api => ... v0.0.0-20260322122346-7de1aab139a0
models replace: 141:	github.com/openshift/assisted-service/models => ... v0.0.0-20260323142108-ec3e2e45bc04
WARNING: api/models are pinned to different assisted-service commits.

Upstream api module declares models v0.0.0 as a dependency with local replace => ../models, confirming tight coupling. Align both to the same verified-compatible upstream snapshot.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@go.mod` around lines 140 - 141, The two replaces for
github.com/openshift/assisted-service are pinned to different commits
(github.com/openshift/assisted-service/api => ...7de1aab139a0 and
github.com/openshift/assisted-service/models => ...ec3e2e45bc04); update the
go.mod so both module replaces point to the same upstream commit hash (choose
one canonical commit and set both github.com/openshift/assisted-service/api and
github.com/openshift/assisted-service/models to that same
v0.0.0-<timestamp>-<commit> value) to eliminate schema/type drift between api
and models.

@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 4d07dcd to 37daddc Compare March 24, 2026 08:14
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to ec3e2e4 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 973000c Mar 24, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 37daddc to 3a55e24 Compare March 24, 2026 12:31
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 973000c NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 2779d00 Mar 24, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 3a55e24 to 7516095 Compare March 24, 2026 17:39
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 2779d00 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 8221039 Mar 24, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 7516095 to 01461e3 Compare March 25, 2026 12:29
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 8221039 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 6989bc2 Mar 25, 2026
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 6989bc2 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to afdca2f Mar 25, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 01461e3 to d4de731 Compare March 26, 2026 04:26
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to afdca2f NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 9f1a838 Mar 26, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from d4de731 to c626078 Compare March 26, 2026 16:23
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 9f1a838 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 36d8cb7 Mar 26, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from c626078 to 423de4b Compare March 26, 2026 20:37
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 36d8cb7 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 7503bc0 Mar 26, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from 423de4b to a4b6645 Compare March 27, 2026 12:29
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 7503bc0 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to acc8646 Mar 27, 2026
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from a4b6645 to d98af2c Compare March 28, 2026 04:27
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to acc8646 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to d59c041 Mar 28, 2026
…to 86cd2ee

Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux bot force-pushed the konflux/mintmaker/master/github.com-openshift-assisted-service-models-digest branch from d98af2c to 9f85cab Compare March 30, 2026 16:21
@red-hat-konflux red-hat-konflux bot changed the title NO-ISSUE: Update github.com/openshift/assisted-service/models digest to d59c041 NO-ISSUE: Update github.com/openshift/assisted-service/models digest to 86cd2ee Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant